Add some debug logging code to AllocateFile's failure path to log the

tglsfdc · tglsfdc · commit f836c2e37e20 · 2006-08-24T03:15:43.000Z
specific Windows error code (GetLastError).  This is a hopefully temporary
hack to try to diagnose rare failures.  Magnus Hagander
diff --git a/src/backend/storage/file/fd.c b/src/backend/storage/file/fd.c
@@ -7,7 +7,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *	  $PostgreSQL: pgsql/src/backend/storage/file/fd.c,v 1.128 2006/05/30 13:04:59 momjian Exp $
+ *	  $PostgreSQL: pgsql/src/backend/storage/file/fd.c,v 1.129 2006/08/24 03:15:43 tgl Exp $
  *
  * NOTES:
  *
@@ -1278,6 +1278,20 @@ AllocateFile(const char *name, const char *mode)
 		errno = save_errno;
 	}
 
+	/*
+	 * TEMPORARY hack to log the Windows error code on fopen failures,
+	 * in hopes of diagnosing some hard-to-reproduce problems.
+	 */
+#ifdef WIN32
+	{
+		int			save_errno = errno;
+
+		elog(LOG, "Windows fopen(\"%s\",\"%s\") failed: code %lu, errno %d",
+			 name, mode, GetLastError(), save_errno);
+		errno = save_errno;
+	}
+#endif
+
 	return NULL;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@`
`7`	`7`	`* Portions Copyright (c) 1994, Regents of the University of California`
`8`	`8`	`*`
`9`	`9`	`* IDENTIFICATION`
`10`		`- * $PostgreSQL: pgsql/src/backend/storage/file/fd.c,v 1.128 2006/05/30 13:04:59 momjian Exp $`
	`10`	`+ * $PostgreSQL: pgsql/src/backend/storage/file/fd.c,v 1.129 2006/08/24 03:15:43 tgl Exp $`
`11`	`11`	`*`
`12`	`12`	`* NOTES:`
`13`	`13`	`*`
`@@ -1278,6 +1278,20 @@ AllocateFile(const char name, const char mode)`
`1278`	`1278`	`errno = save_errno;`
`1279`	`1279`	`}`
`1280`	`1280`
	`1281`	`+ /*`
	`1282`	`+ * TEMPORARY hack to log the Windows error code on fopen failures,`
	`1283`	`+ * in hopes of diagnosing some hard-to-reproduce problems.`
	`1284`	`+ */`
	`1285`	`+#ifdef WIN32`
	`1286`	`+ {`
	`1287`	`+ int save_errno = errno;`
	`1288`	`+`
	`1289`	`+ elog(LOG, "Windows fopen(\"%s\",\"%s\") failed: code %lu, errno %d",`
	`1290`	`+ name, mode, GetLastError(), save_errno);`
	`1291`	`+ errno = save_errno;`
	`1292`	`+ }`
	`1293`	`+#endif`
	`1294`	`+`
`1281`	`1295`	`return NULL;`
`1282`	`1296`	`}`
`1283`	`1297`