Using pytest [assertFalse]

dmitry-lipetsk · dmitry-lipetsk · commit 1cb664e5cd85 · 2025-02-23T23:35:58.000+03:00
diff --git a/tests/test_simple.py b/tests/test_simple.py
@@ -131,7 +131,7 @@ def test_custom_init(self):
                 self.assertGreaterEqual(len(lines), 6)
 
                 # there should be no trust entries at all
-                self.assertFalse(any('trust' in s for s in lines))
+                assert not (any('trust' in s for s in lines))
 
     def test_double_init(self):
         with get_new_node().init() as node:
@@ -190,7 +190,7 @@ def test_node_exit(self):
             base_dir = node.base_dir
 
         # should have been removed by default
-        self.assertFalse(os.path.exists(base_dir))
+        assert not (os.path.exists(base_dir))
 
     def test_double_start(self):
         with get_new_node().init().start() as node:
@@ -245,8 +245,8 @@ def test_pg_ctl(self):
 
     def test_status(self):
         self.assertTrue(NodeStatus.Running)
-        self.assertFalse(NodeStatus.Stopped)
-        self.assertFalse(NodeStatus.Uninitialized)
+        assert not (NodeStatus.Stopped)
+        assert not (NodeStatus.Uninitialized)
 
         # check statuses after each operation
         with get_new_node() as node:
@@ -812,7 +812,7 @@ def test_pg_config(self):
         # modify setting for this scope
         with scoped_config(cache_pg_config=False) as config:
             # sanity check for value
-            self.assertFalse(config.cache_pg_config)
+            assert not (config.cache_pg_config)
 
             # save right after config change
             c2 = get_pg_config()
@@ -1077,7 +1077,7 @@ def test_the_same_port(self):
             with get_new_node(port=node.port) as node2:
                 self.assertEqual(type(node2.port), int)
                 self.assertEqual(node2.port, node.port)
-                self.assertFalse(node2._should_free_port)
+                assert not (node2._should_free_port)
 
                 with pytest.raises(
                     expected_exception=StartNodeException,
@@ -1247,7 +1247,7 @@ def test_port_conflict(self):
                     self.assertTrue(node2._should_free_port)
                     self.assertEqual(__class__.tagPortManagerProxy.sm_DummyPortCurrentUsage, 1)
                     self.assertEqual(__class__.tagPortManagerProxy.sm_DummyPortTotalUsage, C_COUNT_OF_BAD_PORT_USAGE)
-                    self.assertFalse(node2.is_started)
+                    assert not (node2.is_started)
 
                 # node2 must release our dummyPort (node1.port)
                 self.assertEqual(__class__.tagPortManagerProxy.sm_DummyPortCurrentUsage, 0)
diff --git a/tests/test_simple_remote.py b/tests/test_simple_remote.py
@@ -118,7 +118,7 @@ def test_custom_init(self):
             self.assertGreaterEqual(len(lines), 6)
 
             # there should be no trust entries at all
-            self.assertFalse(any('trust' in s for s in lines))
+            assert not (any('trust' in s for s in lines))
 
     def test_init__LANG_С(self):
         # PBCKP-1744
@@ -247,7 +247,7 @@ def test_node_exit(self):
             base_dir = node.base_dir
 
         # should have been removed by default
-        self.assertFalse(os_ops.path_exists(base_dir))
+        assert not (os_ops.path_exists(base_dir))
 
     def test_double_start(self):
         with get_remote_node(conn_params=conn_params).init().start() as node:
@@ -302,8 +302,8 @@ def test_pg_ctl(self):
 
     def test_status(self):
         self.assertTrue(NodeStatus.Running)
-        self.assertFalse(NodeStatus.Stopped)
-        self.assertFalse(NodeStatus.Uninitialized)
+        assert not (NodeStatus.Stopped)
+        assert not (NodeStatus.Uninitialized)
 
         # check statuses after each operation
         with get_remote_node(conn_params=conn_params) as node:
@@ -859,7 +859,7 @@ def test_pg_config(self):
         # modify setting for this scope
         with scoped_config(cache_pg_config=False) as config:
             # sanity check for value
-            self.assertFalse(config.cache_pg_config)
+            assert not (config.cache_pg_config)
 
             # save right after config change
             c2 = get_pg_config()
