Allow only an absolute backup dir prefix

postgres-dev · postgres-dev · commit 4d3dd7043d65 · 2024-01-31T23:24:18.000+07:00
diff --git a/testgres/plugins/pg_probackup2/pg_probackup2/storage/fs_backup.py b/testgres/plugins/pg_probackup2/pg_probackup2/storage/fs_backup.py
@@ -43,11 +43,13 @@ class FSTestBackupDir(TestBackupDir):
     """ Backup directory. Usually created by running pg_probackup init -B <path>"""
 
     def __init__(self, *, rel_path, backup):
-        backup_prefix = os.environ.get('PG_PROBACKUP_TEST_BACKUP_DIR_PREFIX', '')
-        if os.path.isabs(backup_prefix):
+        backup_prefix = os.environ.get('PG_PROBACKUP_TEST_BACKUP_DIR_PREFIX')
+        if backup_prefix:
+            if not os.path.isabs(backup_prefix):
+                raise Exception(f"PG_PROBACKUP_TEST_BACKUP_DIR_PREFIX must be an absolute path, current value: {backup_prefix}")
             self.path = os.path.join(backup_prefix, rel_path, backup)
         else:
-            self.path = os.path.join(init_params.tmp_path, backup_prefix, rel_path, backup)
+            self.path = os.path.join(init_params.tmp_path, rel_path, backup)
         self.pb_args = ('-B', self.path)
 
     def list_instance_backups(self, instance):
