Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cf/6262~1
Choose a base ref
...
head repository: postgresql-cfbot/postgresql
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: cf/6262
Choose a head ref
  • 14 commits
  • 66 files changed
  • 2 contributors

Commits on Dec 26, 2025

  1. cleanup: rename loop variables to avoid local shadowing 

    This commit adjusts several code locations where a local variable was
shadowed by another in the same scope. The changes update loop-variable
names in basebackup_incremental.c and parse_target.c so that each
variable is uniquely scoped within its block.

Author: Chao Li <[email protected]>
Reviewed-by: Peter Smith <[email protected]>
Reviewed-by: Álvaro Herrera <[email protected]>
Discussion: https://postgr.es/m/CAEoWx2kQ2x5gMaj8tHLJ3=jfC+p5YXHkJyHrDTiQw2nn2FJTmQ@mail.gmail.com
    Chao Li (Evan) authored and Commitfest Bot committed Dec 26, 2025
    Configuration menu
    Copy the full SHA
    d4fb2c7 View commit details
    Browse the repository at this point in the history

  2. cleanup: rename inner variables to avoid shadowing by outer locals 

    This commit fixes several cases where a variable declared in an inner
scope was shadowed by an existing local variable in the outer scope. The
changes rename the inner variables so each identifier is distinct within
its respective block.

Author: Chao Li <[email protected]>
Reviewed-by: Peter Smith <[email protected]>
Discussion: https://postgr.es/m/CAEoWx2kQ2x5gMaj8tHLJ3=jfC+p5YXHkJyHrDTiQw2nn2FJTmQ@mail.gmail.com
    Chao Li (Evan) authored and Commitfest Bot committed Dec 26, 2025
    Configuration menu
    Copy the full SHA
    034ec11 View commit details
    Browse the repository at this point in the history

  3. cleanup: rename outer variables to avoid shadowing inner locals 

    This commit resolves several cases where an outer-scope variable shared
a name with a more frequently used inner variable. The fixes rename the
outer variables so each identifier remains distinct within its scope.

Author: Chao Li <[email protected]>
Reviewed-by: Peter Smith <[email protected]>
Discussion: https://postgr.es/m/CAEoWx2kQ2x5gMaj8tHLJ3=jfC+p5YXHkJyHrDTiQw2nn2FJTmQ@mail.gmail.com
    Chao Li (Evan) authored and Commitfest Bot committed Dec 26, 2025
    Configuration menu
    Copy the full SHA
    e7738f0 View commit details
    Browse the repository at this point in the history

  4. cleanup: fix macro-induced variable shadowing in inval.c 

    This commit resolves a shadowing issue in inval.c where variables defined
inside the ProcessMessageSubGroup and ProcessMessageSubGroupMulti macros
conflicted with an existing local name. The fix renames the macro-scoped
variable so it no longer shadows the local variable at the call site.

Author: Chao Li <[email protected]>
Discussion: https://postgr.es/m/CAEoWx2kQ2x5gMaj8tHLJ3=jfC+p5YXHkJyHrDTiQw2nn2FJTmQ@mail.gmail.com
    Chao Li (Evan) authored and Commitfest Bot committed Dec 26, 2025
    Configuration menu
    Copy the full SHA
    712548c View commit details
    Browse the repository at this point in the history

  5. cleanup: avoid local wal_level and wal_segment_size being shadowed by… 

    … globals

This commit fixes cases where local variables named wal_level and
wal_segment_size were shadowed by global identifiers of the same names.
The local variables are renamed so they are no longer shadowed by the
globals.

Author: Chao Li <[email protected]>
Reviewed-by: Andres Freund <[email protected]>
Discussion: https://postgr.es/m/CAEoWx2kQ2x5gMaj8tHLJ3=jfC+p5YXHkJyHrDTiQw2nn2FJTmQ@mail.gmail.com
    Chao Li (Evan) authored and Commitfest Bot committed Dec 26, 2025
    Configuration menu
    Copy the full SHA
    218bcdd View commit details
    Browse the repository at this point in the history

  6. cleanup: avoid local variables shadowed by static file-scope ones in … 

    …xlogrecovery.c

This commit fixes several cases in xlogrecovery.c where local variables
used names that conflicted with static variables defined at file scope.
The local identifiers are renamed so they are no longer shadowed by the
static ones.

Author: Chao Li <[email protected]>
Discussion: https://postgr.es/m/CAEoWx2kQ2x5gMaj8tHLJ3=jfC+p5YXHkJyHrDTiQw2nn2FJTmQ@mail.gmail.com
    Chao Li (Evan) authored and Commitfest Bot committed Dec 26, 2025
    Configuration menu
    Copy the full SHA
    6eff876 View commit details
    Browse the repository at this point in the history

  7. cleanup: rename local progname variables to avoid shadowing the global 

    This commit updates all functions that declared a local variable named
'progname', renaming each to 'myprogname'. The change prevents shadowing
of the global progname variable and keeps identifier usage unambiguous
within each scope.

A few additional shadowing fixes in the same files are included as well.
These unrelated cases are addressed here only because they occur in the
same code locations touched by the progname change, and bundling them
keeps the commit self-contained.

Author: Chao Li <[email protected]>
Discussion: https://postgr.es/m/CAEoWx2kQ2x5gMaj8tHLJ3=jfC+p5YXHkJyHrDTiQw2nn2FJTmQ@mail.gmail.com
    Chao Li (Evan) authored and Commitfest Bot committed Dec 26, 2025
    Configuration menu
    Copy the full SHA
    a4c7781 View commit details
    Browse the repository at this point in the history

  8. cleanup: avoid local variables shadowed by static file-scope ones in … 

    …file_ops.c

This commit fixes several cases in file_ops.c where local variables used
names that conflicted with static variables defined at file scope. The
local identifiers are renamed so they are no longer shadowed by the file-
scope variables and remain unambiguous within their respective blocks.

Author: Chao Li <[email protected]>
Discussion: https://postgr.es/m/CAEoWx2kQ2x5gMaj8tHLJ3=jfC+p5YXHkJyHrDTiQw2nn2FJTmQ@mail.gmail.com
    Chao Li (Evan) authored and Commitfest Bot committed Dec 26, 2025
    Configuration menu
    Copy the full SHA
    e958c11 View commit details
    Browse the repository at this point in the history

  9. cleanup: avoid local variables shadowed by globals across several files 

    This commit fixes multiple instances where local variables used the same
names as global identifiers in various modules. The affected locals are
renamed so they are no longer shadowed by the globals and remain clear
within their respective scopes.

Author: Chao Li <[email protected]>
Discussion: https://postgr.es/m/CAEoWx2kQ2x5gMaj8tHLJ3=jfC+p5YXHkJyHrDTiQw2nn2FJTmQ@mail.gmail.com
    Chao Li (Evan) authored and Commitfest Bot committed Dec 26, 2025
    Configuration menu
    Copy the full SHA
    b0e272a View commit details
    Browse the repository at this point in the history

  10. cleanup: avoid local variables shadowed by static file-scope ones in … 

    …several files

This commit fixes multiple cases where local variables used names that
conflicted with static variables defined at file scope. The affected
locals are renamed so they are no longer shadowed by the file-scope
identifiers and remain unambiguous within their respective scopes.

Author: Chao Li <[email protected]>
Discussion: https://postgr.es/m/CAEoWx2kQ2x5gMaj8tHLJ3=jfC+p5YXHkJyHrDTiQw2nn2FJTmQ@mail.gmail.com
    Chao Li (Evan) authored and Commitfest Bot committed Dec 26, 2025
    Configuration menu
    Copy the full SHA
    4824cdb View commit details
    Browse the repository at this point in the history

  11. cleanup: rename local conn variables to avoid shadowing the global 

    This commit renames all local variables named 'conn' to 'myconn' to avoid
shadowing the global connection variable. This ensures the local and
global identifiers remain clearly distinct within each scope.

A few additional shadowing fixes in the same code areas are included as
well. These are unrelated to the conn renaming but occur in the same
files, so they are bundled here to keep the commit self-contained.

Author: Chao Li <[email protected]>
Discussion: https://postgr.es/m/CAEoWx2kQ2x5gMaj8tHLJ3=jfC+p5YXHkJyHrDTiQw2nn2FJTmQ@mail.gmail.com
    Chao Li (Evan) authored and Commitfest Bot committed Dec 26, 2025
    Configuration menu
    Copy the full SHA
    298a535 View commit details
    Browse the repository at this point in the history

  12. cleanup: avoid local variables shadowed by globals in ecpg.header 

    This commit renames local variables in ecpg.header that were shadowed by
global identifiers of the same names. The updated local names ensure the
identifiers remain distinct and unambiguous within the file.

Author: Chao Li <[email protected]>
Discussion: https://postgr.es/m/CAEoWx2kQ2x5gMaj8tHLJ3=jfC+p5YXHkJyHrDTiQw2nn2FJTmQ@mail.gmail.com
    Chao Li (Evan) authored and Commitfest Bot committed Dec 26, 2025
    Configuration menu
    Copy the full SHA
    b50c92d View commit details
    Browse the repository at this point in the history

  13. cleanup: avoid local variables shadowed by globals across time-relate… 

    …d modules

This commit renames several local variables in date/time and timezone
code that were shadowed by global identifiers of the same names. The
updated local identifiers ensure clearer separation of scope throughout
the affected modules.

A few additional shadowing fixes in the same code areas are included as
well. These are unrelated to the conn renaming but occur in the same
files, so they are bundled here to keep the commit self-contained.

Author: Chao Li <[email protected]>
Discussion: https://postgr.es/m/CAEoWx2kQ2x5gMaj8tHLJ3=jfC+p5YXHkJyHrDTiQw2nn2FJTmQ@mail.gmail.com
    Chao Li (Evan) authored and Commitfest Bot committed Dec 26, 2025
    Configuration menu
    Copy the full SHA
    0bcbac5 View commit details
    Browse the repository at this point in the history

  14. [CF 6262] v5 - Cleanup shadows variable warnings 

    This branch was automatically generated by a robot using patches from an
email thread registered at:

https://commitfest.postgresql.org/patch/6262

The branch will be overwritten each time a new patch version is posted to
the thread, and also periodically to check for bitrot caused by changes
on the master branch.

Patch(es): https://www.postgresql.org/message-id/CAEoWx2mrQt1ymaCFkrO2bKe01sdRBSxOWBCEPxzJU2k4TpNttg@mail.gmail.com
Author(s): Chao Li
    Commitfest Bot committed Dec 26, 2025
    Configuration menu
    Copy the full SHA
    27cd2b1 View commit details
    Browse the repository at this point in the history
Loading