Fix more attributes

andrewmy · andrewmy · commit 2b33202713a6 · 2021-01-24T21:11:36.000+02:00
diff --git a/pkg/rdkafka/Tests/RdKafkaConnectionFactoryConfigTest.php b/pkg/rdkafka/Tests/RdKafkaConnectionFactoryConfigTest.php
@@ -4,6 +4,7 @@
 
 use Enqueue\RdKafka\RdKafkaConnectionFactory;
 use Enqueue\Test\ClassExtensionTrait;
+use Enqueue\Test\ReadAttributeTrait;
 use PHPUnit\Framework\TestCase;
 
 /**
@@ -12,6 +13,7 @@
 class RdKafkaConnectionFactoryConfigTest extends TestCase
 {
     use ClassExtensionTrait;
+    use ReadAttributeTrait;
 
     public function testThrowNeitherArrayStringNorNullGivenAsConfig()
     {
@@ -39,7 +41,7 @@ public function testShouldParseConfigurationAsExpected($config, $expectedConfig)
     {
         $factory = new RdKafkaConnectionFactory($config);
 
-        $config = $this->getObjectAttribute($factory, 'config');
+        $config = $this->readAttribute($factory, 'config');
 
         $this->assertNotEmpty($config['global']['group.id']);
 
diff --git a/pkg/rdkafka/Tests/RdKafkaConnectionFactoryTest.php b/pkg/rdkafka/Tests/RdKafkaConnectionFactoryTest.php
@@ -41,7 +41,7 @@ public function testShouldBeExpectedDefaultConfig()
     {
         $factory = new RdKafkaConnectionFactory(null);
 
-        $config = $this->getObjectAttribute($factory, 'config');
+        $config = $this->readAttribute($factory, 'config');
 
         $this->assertNotEmpty($config['global']['group.id']);
 
@@ -58,7 +58,7 @@ public function testShouldBeExpectedDefaultDsnConfig()
     {
         $factory = new RdKafkaConnectionFactory('kafka:');
 
-        $config = $this->getObjectAttribute($factory, 'config');
+        $config = $this->readAttribute($factory, 'config');
 
         $this->assertNotEmpty($config['global']['group.id']);
 

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@`
`4`	`4`
`5`	`5`	`use Enqueue\RdKafka\RdKafkaConnectionFactory;`
`6`	`6`	`use Enqueue\Test\ClassExtensionTrait;`
	`7`	`+use Enqueue\Test\ReadAttributeTrait;`
`7`	`8`	`use PHPUnit\Framework\TestCase;`
`8`	`9`
`9`	`10`	`/**`
`@@ -12,6 +13,7 @@`
`12`	`13`	`class RdKafkaConnectionFactoryConfigTest extends TestCase`
`13`	`14`	`{`
`14`	`15`	`use ClassExtensionTrait;`
	`16`	`+ use ReadAttributeTrait;`
`15`	`17`
`16`	`18`	`public function testThrowNeitherArrayStringNorNullGivenAsConfig()`
`17`	`19`	`{`
`@@ -39,7 +41,7 @@ public function testShouldParseConfigurationAsExpected($config, $expectedConfig)`
`39`	`41`	`{`
`40`	`42`	`$factory = new RdKafkaConnectionFactory($config);`
`41`	`43`
`42`		`- $config = $this->getObjectAttribute($factory, 'config');`
	`44`	`+ $config = $this->readAttribute($factory, 'config');`
`43`	`45`
`44`	`46`	`$this->assertNotEmpty($config['global']['group.id']);`
`45`	`47`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public function testShouldBeExpectedDefaultConfig()`
`41`	`41`	`{`
`42`	`42`	`$factory = new RdKafkaConnectionFactory(null);`
`43`	`43`
`44`		`- $config = $this->getObjectAttribute($factory, 'config');`
	`44`	`+ $config = $this->readAttribute($factory, 'config');`
`45`	`45`
`46`	`46`	`$this->assertNotEmpty($config['global']['group.id']);`
`47`	`47`
`@@ -58,7 +58,7 @@ public function testShouldBeExpectedDefaultDsnConfig()`
`58`	`58`	`{`
`59`	`59`	`$factory = new RdKafkaConnectionFactory('kafka:');`
`60`	`60`
`61`		`- $config = $this->getObjectAttribute($factory, 'config');`
	`61`	`+ $config = $this->readAttribute($factory, 'config');`
`62`	`62`
`63`	`63`	`$this->assertNotEmpty($config['global']['group.id']);`
`64`	`64`