fix parse_shebang_from_file for windows store python

asottile · asottile · commit 038f00b7cfe4 · 2021-03-08T18:44:48.000-08:00
diff --git a/identify/identify.py b/identify/identify.py
@@ -1,3 +1,4 @@
+import errno
 import os.path
 import re
 import shlex
@@ -205,8 +206,14 @@ def parse_shebang_from_file(path: str) -> Tuple[str, ...]:
     if not os.access(path, os.X_OK):
         return ()
 
-    with open(path, 'rb') as f:
-        return parse_shebang(f)
+    try:
+        with open(path, 'rb') as f:
+            return parse_shebang(f)
+    except OSError as e:
+        if e.errno == errno.EINVAL:
+            return ()
+        else:
+            raise
 
 
 COPYRIGHT_RE = re.compile(r'^\s*(Copyright|\(C\)) .*$', re.I | re.MULTILINE)
diff --git a/tests/identify_test.py b/tests/identify_test.py
@@ -1,8 +1,11 @@
+import builtins
+import errno
 import io
 import os
 import socket
 import stat
 from tempfile import TemporaryDirectory
+from unittest import mock
 
 import pytest
 
@@ -330,6 +333,15 @@ def test_parse_shebang_from_file_simple(tmpdir):
     assert identify.parse_shebang_from_file(x.strpath) == ('python',)
 
 
+def test_parse_shebang_open_raises_einval(tmpdir):
+    x = tmpdir.join('f')
+    x.write('#!/usr/bin/env not-expected\n')
+    make_executable(x)
+    error = OSError(errno.EINVAL, f'Invalid argument {x}')
+    with mock.patch.object(builtins, 'open', side_effect=error):
+        assert identify.parse_shebang_from_file(x.strpath) == ()
+
+
 def make_executable(filename):
     original_mode = os.stat(filename).st_mode
     os.chmod(
