Merge pull request #981 from tristan0x/fix/infinite-process-recursion

asottile · web-flow · commit 03ac3b0840af · 2019-03-30T13:54:42.000-07:00
Do not run legacy script again when this is the one being executed
diff --git a/pre_commit/resources/hook-tmpl b/pre_commit/resources/hook-tmpl
@@ -49,6 +49,16 @@ def _norm_exe(exe):
 
 
 def _run_legacy():
+    if __file__.endswith('.legacy'):
+        raise SystemExit(
+            "bug: pre-commit's script is installed in migration mode\n"
+            'run `pre-commit install -f --hook-type {}` to fix this\n\n'
+            'Please report this bug at '
+            'https://github.com/pre-commit/pre-commit/issues'.format(
+                HOOK_TYPE,
+            ),
+        )
+
     if HOOK_TYPE == 'pre-push':
         stdin = getattr(sys.stdin, 'buffer', sys.stdin).read()
     else:
