Address PR feedback

ashanbrown · ashanbrown · commit 1eed1b51b871 · 2019-01-27T17:55:11.000-08:00
diff --git a/pre_commit/languages/golang.py b/pre_commit/languages/golang.py
@@ -7,7 +7,6 @@
 import pre_commit.constants as C
 from pre_commit import git
 from pre_commit.envcontext import envcontext
-from pre_commit.envcontext import UNSET
 from pre_commit.envcontext import Var
 from pre_commit.languages import helpers
 from pre_commit.util import clean_path_on_failure
@@ -22,7 +21,6 @@
 
 def get_env_patch(venv):
     return (
-        ('GOBIN', UNSET),
         ('PATH', (os.path.join(venv, 'bin'), os.pathsep, Var('PATH'))),
     )
 
diff --git a/tests/repository_test.py b/tests/repository_test.py
@@ -72,7 +72,7 @@ def _test_hook_repo(
     path = make_repo(tempdir_factory, repo_path)
     config = make_config_from_repo(path, **(config_kwargs or {}))
     ret = _get_hook(config, store, hook_id).run(args)
-    assert ret[0] == expected_return_code, "output was: {}".format(ret[1])
+    assert ret[0] == expected_return_code
     assert _norm_out(ret[1]) == expected
 
 
@@ -271,11 +271,8 @@ def test_golang_hook(tempdir_factory, store):
 def test_golang_hook_still_works_when_gobin_is_set(tempdir_factory, store):
     gobin_dir = tempdir_factory.get()
     with envcontext([('GOBIN', gobin_dir)]):
-        _test_hook_repo(
-            tempdir_factory, store, 'golang_hooks_repo',
-            'golang-hook', [], b'hello world\n',
-        )
-    assert os.listdir(gobin_dir) == [], "hook must not be installed in $GOBIN"
+        test_golang_hook(tempdir_factory, store)
+    assert os.listdir(gobin_dir) == []
 
 
 def test_rust_hook(tempdir_factory, store):
