os.symlink is always an attribute in py3

asottile · asottile · commit 251721b890a2 · 2020-01-12T13:39:53.000-08:00
diff --git a/testing/util.py b/testing/util.py
@@ -45,12 +45,6 @@ def cmd_output_mocked_pre_commit_home(
 xfailif_windows = pytest.mark.xfail(os.name == 'nt', reason='windows')
 
 
-xfailif_no_symlink = pytest.mark.xfail(
-    not hasattr(os, 'symlink'),
-    reason='Symlink is not supported on this platform',
-)
-
-
 def supports_venv():  # pragma: no cover (platform specific)
     try:
         __import__('ensurepip')
diff --git a/tests/commands/install_uninstall_test.py b/tests/commands/install_uninstall_test.py
@@ -21,7 +21,6 @@
 from testing.util import cmd_output_mocked_pre_commit_home
 from testing.util import cwd
 from testing.util import git_commit
-from testing.util import xfailif_no_symlink
 from testing.util import xfailif_windows
 
 
@@ -89,7 +88,6 @@ def test_install_refuses_core_hookspath(in_git_dir, store):
     assert install(C.CONFIG_FILE, store, hook_types=['pre-commit'])
 
 
-@xfailif_no_symlink  # pragma: windows no cover
 def test_install_hooks_dead_symlink(in_git_dir, store):
     hook = in_git_dir.join('.git/hooks').ensure_dir().join('pre-commit')
     os.symlink('/fake/baz', hook.strpath)
diff --git a/tests/commands/run_test.py b/tests/commands/run_test.py
@@ -27,7 +27,6 @@
 from testing.util import cwd
 from testing.util import git_commit
 from testing.util import run_opts
-from testing.util import xfailif_no_symlink
 
 
 @pytest.fixture
@@ -861,7 +860,6 @@ def test_include_exclude_base_case(some_filenames):
     ]
 
 
-@xfailif_no_symlink  # pragma: windows no cover
 def test_matches_broken_symlink(tmpdir):
     with tmpdir.as_cwd():
         os.symlink('does-not-exist', 'link')
