improve coverage pragmas with covdefaults 2.1

asottile · asottile · commit 270b539e8f1d · 2021-11-29T20:45:40.000-05:00
Committed via https://github.com/asottile/all-repos
diff --git a/pre_commit/constants.py b/pre_commit/constants.py
@@ -1,9 +1,9 @@
 import sys
 
-if sys.version_info < (3, 8):  # pragma: no cover (<PY38)
-    import importlib_metadata
-else:  # pragma: no cover (PY38+)
+if sys.version_info >= (3, 8):  # pragma: >=3.8 cover
     import importlib.metadata as importlib_metadata
+else:  # pragma: <3.8 cover
+    import importlib_metadata
 
 CONFIG_FILE = '.pre-commit-config.yaml'
 MANIFEST_FILE = '.pre-commit-hooks.yaml'
diff --git a/pre_commit/util.py b/pre_commit/util.py
@@ -21,10 +21,10 @@
 
 from pre_commit import parse_shebang
 
-if sys.version_info >= (3, 7):  # pragma: no cover (PY37+)
+if sys.version_info >= (3, 7):  # pragma: >=3.7 cover
     from importlib.resources import open_binary
     from importlib.resources import read_text
-else:  # pragma: no cover (<PY37)
+else:  # pragma: <3.7 cover
     from importlib_resources import open_binary
     from importlib_resources import read_text
 
diff --git a/requirements-dev.txt b/requirements-dev.txt
@@ -1,4 +1,4 @@
-covdefaults
+covdefaults>=2.1
 coverage
 distlib
 pytest
diff --git a/tests/repository_test.py b/tests/repository_test.py
@@ -164,7 +164,7 @@ def test_python_hook_weird_setup_cfg(in_git_dir, tempdir_factory, store):
     )
 
 
-def test_python_venv(tempdir_factory, store):  # pragma: no cover (no venv)
+def test_python_venv(tempdir_factory, store):
     _test_hook_repo(
         tempdir_factory, store, 'python_venv_hooks_repo',
         'foo', [os.devnull],

Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ def test_python_hook_weird_setup_cfg(in_git_dir, tempdir_factory, store):`
`164`	`164`	`)`
`165`	`165`
`166`	`166`
`167`		`-def test_python_venv(tempdir_factory, store): # pragma: no cover (no venv)`
	`167`	`+def test_python_venv(tempdir_factory, store):`
`168`	`168`	`_test_hook_repo(`
`169`	`169`	`tempdir_factory, store, 'python_venv_hooks_repo',`
`170`	`170`	`'foo', [os.devnull],`