Install hooks before attempting to run anything

asottile · asottile · commit 31a3b2ecb6cb · 2014-07-04T11:11:21.000-07:00
diff --git a/pre_commit/runner.py b/pre_commit/runner.py
@@ -37,7 +37,10 @@ def config_file_path(self):
     def repositories(self):
         """Returns a tuple of the configured repositories."""
         config = load_config(self.config_file_path)
-        return tuple(Repository.create(x, self.store) for x in config)
+        repositories = tuple(Repository.create(x, self.store) for x in config)
+        for repository in repositories:
+            repository.require_installed()
+        return repositories
 
     @cached_property
     def pre_commit_path(self):
diff --git a/testing/resources/consumer_repo/.pre-commit-config.yaml b/testing/resources/consumer_repo/.pre-commit-config.yaml
diff --git a/tests/runner_test.py b/tests/runner_test.py
@@ -8,7 +8,7 @@
 import pre_commit.constants as C
 from pre_commit.runner import Runner
 from testing.fixtures import git_dir
-from testing.fixtures import make_repo
+from testing.fixtures import make_consuming_repo
 
 
 def test_init_has_no_side_effects(tmpdir):
@@ -47,14 +47,9 @@ def test_config_file_path():
 
 
 def test_repositories(tmpdir_factory, mock_out_store_directory):
-    # TODO: make this not have external deps
-    path = make_repo(tmpdir_factory, 'consumer_repo')
+    path = make_consuming_repo(tmpdir_factory, 'script_hooks_repo')
     runner = Runner(path)
-    assert len(runner.repositories) == 2
-    assert [repo.repo_url for repo in runner.repositories] == [
-        'git@github.com:pre-commit/pre-commit-hooks',
-        'git@github.com:pre-commit/pre-commit',
-    ]
+    assert len(runner.repositories) == 1
 
 
 def test_pre_commit_path():
