Clarify language around missing hooks. Resolves #386

asottile · asottile · commit 5547db93ef02 · 2016-06-25T08:14:58.000-07:00
diff --git a/pre_commit/repository.py b/pre_commit/repository.py
@@ -78,7 +78,9 @@ def hooks(self):
                 logger.error(
                     '`{0}` is not present in repository {1}.  '
                     'Typo? Perhaps it is introduced in a newer version?  '
-                    'Often `pre-commit autoupdate` fixes this.'.format(
+                    'Often you can fix this by removing the hook, running '
+                    '`pre-commit autoupdate`, '
+                    'and then adding the hook.'.format(
                         hook['id'], self.repo_config['repo'],
                     )
                 )
diff --git a/tests/repository_test.py b/tests/repository_test.py
@@ -556,7 +556,9 @@ def test_hook_id_not_present(tempdir_factory, store, fake_log_handler):
     assert fake_log_handler.handle.call_args[0][0].msg == (
         '`i-dont-exist` is not present in repository {0}.  '
         'Typo? Perhaps it is introduced in a newer version?  '
-        'Often `pre-commit autoupdate` fixes this.'.format(path)
+        'Often you can fix this by removing the hook, '
+        'running `pre-commit autoupdate`, '
+        'and then adding the hook.'.format(path)
     )
 
 

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,9 @@ def hooks(self):`
`78`	`78`	`logger.error(`
`79`	`79`	'`{0}` is not present in repository {1}. '
`80`	`80`	`'Typo? Perhaps it is introduced in a newer version? '`
`81`		- 'Often `pre-commit autoupdate` fixes this.'.format(
	`81`	`+ 'Often you can fix this by removing the hook, running '`
	`82`	+ '`pre-commit autoupdate`, '
	`83`	`+ 'and then adding the hook.'.format(`
`82`	`84`	`hook['id'], self.repo_config['repo'],`
`83`	`85`	`)`
`84`	`86`	`)`
Original file line number	Diff line number	Diff line change
`@@ -556,7 +556,9 @@ def test_hook_id_not_present(tempdir_factory, store, fake_log_handler):`
`556`	`556`	`assert fake_log_handler.handle.call_args[0][0].msg == (`
`557`	`557`	'`i-dont-exist` is not present in repository {0}. '
`558`	`558`	`'Typo? Perhaps it is introduced in a newer version? '`
`559`		- 'Often `pre-commit autoupdate` fixes this.'.format(path)
	`559`	`+ 'Often you can fix this by removing the hook, '`
	`560`	+ 'running `pre-commit autoupdate`, '
	`561`	`+ 'and then adding the hook.'.format(path)`
`560`	`562`	`)`
`561`	`563`
`562`	`564`