Merge pull request #2917 from pre-commit/py38-shelx-join

asottile · web-flow · commit 8bf22bd3c106 · 2023-07-01T17:33:28.000-04:00
shlex.join is always available in 3.8+
diff --git a/pre_commit/commands/install_uninstall.py b/pre_commit/commands/install_uninstall.py
@@ -103,8 +103,7 @@ def _install_hook_script(
 
         hook_file.write(before + TEMPLATE_START)
         hook_file.write(f'INSTALL_PYTHON={shlex.quote(sys.executable)}\n')
-        # TODO: python3.8+: shlex.join
-        args_s = ' '.join(shlex.quote(part) for part in args)
+        args_s = shlex.join(args)
         hook_file.write(f'ARGS=({args_s})\n')
         hook_file.write(TEMPLATE_END + after)
     make_executable(hook_path)
