be nice about current directory in tests

struys · struys · commit 94370d6e2b57 · 2014-03-13T14:11:50.000-07:00
diff --git a/tests/git_test.py b/tests/git_test.py
@@ -1,25 +1,37 @@
 
+import contextlib
 import os
 import pytest
 
 from plumbum import local
 from pre_commit import git
 
-@pytest.fixture
+
+
+@contextlib.contextmanager
+def in_dir(dir):
+    old_path = local.cwd.getpath()
+    local.cwd.chdir(dir)
+    try:
+        yield
+    finally:
+        local.cwd.chdir(old_path)
+
+@pytest.yield_fixture
 def empty_git_dir(tmpdir):
-    local.cwd.chdir(tmpdir.strpath)
-    local['git']['init']()
-    return tmpdir.strpath
+    with in_dir(tmpdir.strpath):
+        local['git']['init']()
+        yield tmpdir.strpath
 
 
 def test_get_root(empty_git_dir):
     assert git.get_root() == empty_git_dir
 
     foo = local.path('foo')
     foo.mkdir()
-    local.cwd.chdir(foo)
 
-    assert git.get_root() == empty_git_dir
+    with in_dir(foo):
+        assert git.get_root() == empty_git_dir
 
 
 def test_get_pre_commit_path(empty_git_dir):
