Merge pull request #1079 from madkinsz/run-stage-prompt-1078

asottile · web-flow · commit 95afd642f52b · 2019-07-09T12:10:43.000-07:00
Added hook-stage print to output for missing hook id
diff --git a/pre_commit/commands/run.py b/pre_commit/commands/run.py
@@ -285,7 +285,11 @@ def run(config_file, store, args, environ=os.environ):
         ]
 
         if args.hook and not hooks:
-            output.write_line('No hook with id `{}`'.format(args.hook))
+            output.write_line(
+                'No hook with id `{}` in stage `{}`'.format(
+                    args.hook, args.hook_stage,
+                ),
+            )
             return 1
 
         install_hook_envs(hooks, store)
diff --git a/tests/commands/run_test.py b/tests/commands/run_test.py
@@ -231,7 +231,18 @@ def test_show_diff_on_failure(
         ({}, (b'Bash hook', b'Passed'), 0, True),
         ({'verbose': True}, (b'foo.py\nHello World',), 0, True),
         ({'hook': 'bash_hook'}, (b'Bash hook', b'Passed'), 0, True),
-        ({'hook': 'nope'}, (b'No hook with id `nope`',), 1, True),
+        (
+            {'hook': 'nope'},
+            (b'No hook with id `nope` in stage `commit`',),
+            1,
+            True,
+        ),
+        (
+            {'hook': 'nope', 'hook_stage': 'push'},
+            (b'No hook with id `nope` in stage `push`',),
+            1,
+            True,
+        ),
         (
             {'all_files': True, 'verbose': True},
             (b'foo.py',),
