Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit b9bc621

Browse files
committed
Fix some minor windows compatibility things
1 parent de2ead1 commit b9bc621

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

testing/util.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,8 @@ def is_valid_according_to_schema(obj, schema):
6666

6767

6868
def platform_supports_pcre():
69-
return cmd_output('grep', '-P', '', os.devnull, retcode=None)[0] == 1
69+
output = cmd_output('grep', '-P', 'setup', 'setup.py', retcode=None)
70+
return output[0] == 0 and 'from setuptools import setup' in output[1]
7071

7172

7273
xfailif_no_pcre_support = pytest.mark.xfail(

tests/repository_test.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -340,6 +340,7 @@ def test_additional_python_dependencies_installed(tempdir_factory, store):
340340
assert 'mccabe' in output
341341

342342

343+
@xfailif_windows_no_ruby
343344
@pytest.mark.integration
344345
def test_additional_ruby_dependencies_installed(tempdir_factory, store):
345346
path = make_repo(tempdir_factory, 'ruby_hooks_repo')
@@ -352,6 +353,7 @@ def test_additional_ruby_dependencies_installed(tempdir_factory, store):
352353
assert 'thread_safe' in output
353354

354355

356+
@xfailif_windows_no_node
355357
@pytest.mark.integration
356358
def test_additional_node_dependencies_installed(tempdir_factory, store):
357359
path = make_repo(tempdir_factory, 'node_hooks_repo')

0 commit comments

Comments
 (0)