util: also run chmod on EPERM

fsouza · fsouza · commit bb0d9573a9a8 · 2020-12-05T22:26:38.000-05:00
Writing a test for this one is tricky, because I was seeing the issue
only when the directory being removed is a docker volume, so instead of
getting EACCES we get EPERM.

This is easy to reproduce though. The existing test fails when the
directory being used for the files is a docker volume:

```
% docker run \
	-v $(mktemp -d):/tmp \
	-v ${PWD}:/src \
	-w /src \
	python:3 \
	bash -c 'pip install -e . &amp;&amp; pip install -r requirements-dev.txt &amp;&amp; python -m pytest tests/util_test.py'
```
diff --git a/pre_commit/util.py b/pre_commit/util.py
@@ -255,7 +255,7 @@ def handle_remove_readonly(
         excvalue = exc[1]
         if (
                 func in (os.rmdir, os.remove, os.unlink) and
-                excvalue.errno == errno.EACCES
+                excvalue.errno in (errno.EACCES, errno.EPERM)
         ):
             for p in (path, os.path.dirname(path)):
                 os.chmod(p, os.stat(p).st_mode | stat.S_IWUSR)
