Improve messaging for missing hook given #480

asottile · asottile · commit c08400e2bca6 · 2017-01-30T20:43:20.000-08:00
diff --git a/pre_commit/repository.py b/pre_commit/repository.py
@@ -78,9 +78,7 @@ def hooks(self):
                 logger.error(
                     '`{}` is not present in repository {}.  '
                     'Typo? Perhaps it is introduced in a newer version?  '
-                    'Often you can fix this by removing the hook, running '
-                    '`pre-commit autoupdate`, '
-                    'and then adding the hook.'.format(
+                    'Often `pre-commit autoupdate` fixes this.'.format(
                         hook['id'], self.repo_config['repo'],
                     )
                 )
diff --git a/tests/repository_test.py b/tests/repository_test.py
@@ -696,9 +696,7 @@ def test_hook_id_not_present(tempdir_factory, store, fake_log_handler):
     assert fake_log_handler.handle.call_args[0][0].msg == (
         '`i-dont-exist` is not present in repository {}.  '
         'Typo? Perhaps it is introduced in a newer version?  '
-        'Often you can fix this by removing the hook, '
-        'running `pre-commit autoupdate`, '
-        'and then adding the hook.'.format(path)
+        'Often `pre-commit autoupdate` fixes this.'.format(path)
     )
 
 

Original file line number	Diff line number	Diff line change
`@@ -78,9 +78,7 @@ def hooks(self):`
`78`	`78`	`logger.error(`
`79`	`79`	'`{}` is not present in repository {}. '
`80`	`80`	`'Typo? Perhaps it is introduced in a newer version? '`
`81`		`- 'Often you can fix this by removing the hook, running '`
`82`		- '`pre-commit autoupdate`, '
`83`		`- 'and then adding the hook.'.format(`
	`81`	+ 'Often `pre-commit autoupdate` fixes this.'.format(
`84`	`82`	`hook['id'], self.repo_config['repo'],`
`85`	`83`	`)`
`86`	`84`	`)`
Original file line number	Diff line number	Diff line change
`@@ -696,9 +696,7 @@ def test_hook_id_not_present(tempdir_factory, store, fake_log_handler):`
`696`	`696`	`assert fake_log_handler.handle.call_args[0][0].msg == (`
`697`	`697`	'`i-dont-exist` is not present in repository {}. '
`698`	`698`	`'Typo? Perhaps it is introduced in a newer version? '`
`699`		`- 'Often you can fix this by removing the hook, '`
`700`		- 'running `pre-commit autoupdate`, '
`701`		`- 'and then adding the hook.'.format(path)`
	`699`	+ 'Often `pre-commit autoupdate` fixes this.'.format(path)
`702`	`700`	`)`
`703`	`701`
`704`	`702`