Fix test_environment_not_sourced when pre-commit is installed globally

asottile · asottile · commit e868add5a30e · 2019-05-26T17:03:15.000-07:00
diff --git a/azure-pipelines.yml b/azure-pipelines.yml
@@ -10,7 +10,7 @@ resources:
       type: github
       endpoint: github
       name: asottile/azure-pipeline-templates
-      ref: refs/tags/v0.0.13
+      ref: refs/tags/v0.0.14
 
 jobs:
 - template: job--pre-commit.yml@asottile
diff --git a/tests/commands/install_uninstall_test.py b/tests/commands/install_uninstall_test.py
@@ -18,6 +18,7 @@
 from pre_commit.commands.install_uninstall import PRIOR_HASHES
 from pre_commit.commands.install_uninstall import shebang
 from pre_commit.commands.install_uninstall import uninstall
+from pre_commit.parse_shebang import find_executable
 from pre_commit.util import cmd_output
 from pre_commit.util import make_executable
 from pre_commit.util import mkdirp
@@ -234,10 +235,16 @@ def test_install_idempotent(tempdir_factory, store):
 
 def _path_without_us():
     # Choose a path which *probably* doesn't include us
-    return os.pathsep.join([
-        x for x in os.environ['PATH'].split(os.pathsep)
-        if x.lower() != os.path.dirname(sys.executable).lower()
-    ])
+    env = dict(os.environ)
+    exe = find_executable('pre-commit', _environ=env)
+    while exe:
+        parts = env['PATH'].split(os.pathsep)
+        after = [x for x in parts if x.lower() != os.path.dirname(exe).lower()]
+        if parts == after:
+            raise AssertionError(exe, parts)
+        env['PATH'] = os.pathsep.join(after)
+        exe = find_executable('pre-commit', _environ=env)
+    return env['PATH']
 
 
 def test_environment_not_sourced(tempdir_factory, store):
