-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Closed as not planned
Closed as not planned
Copy link
Labels
area:plugin apilocked-due-to-inactivityPlease open a new issue and fill out the template instead of commenting.Please open a new issue and fill out the template instead of commenting.
Description
See #15517 for previous discussion. Since this problem only happens with plugin-xml, they suggested I report it here.
Environments:
- Prettier Version: 3.0.3
- Running Prettier via: pre-commit
- Runtime: Node.js v20
- Operating System: macOS
- Prettier plugins (if any): @prettier/plugin-xml
Steps to reproduce:
Add the following to .pre-commit-config.yaml:
- repo: https://github.com/pre-commit/mirrors-prettier
rev: v3.0.3 # Use the sha / tag you want to point at
hooks:
- id: prettier
additional_dependencies:
- [email protected]
- "@prettier/[email protected]"Add a misformatted XML file, and run pre-commit run --all
Expected behavior:
Formats the XML file
Actual behavior:
[error] Cannot find package '@prettier/plugin-xml' imported from /Users/kevin/src/.../noop.js
I tried a whole bunch of options including adding the plugin option to .prettierrc.yaml or adding a --plugin @prettier/plugin-xml to the args in .pre-commit-config.yaml.
Going back to a pre-v3 version works, which is what I'm going to go back to for now.
I've created an example repo: https://github.com/kamitchell/pre-commit-xml-plugin-example which has an example and more discussion of things I tried.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
area:plugin apilocked-due-to-inactivityPlease open a new issue and fill out the template instead of commenting.Please open a new issue and fill out the template instead of commenting.