From 690e420e78a728ff7fc75755d1fc4e33e7a649ab Mon Sep 17 00:00:00 2001
From: Bob Lyon <Robert.B.Lyon@gmail.com>
Date: Mon, 18 Jul 2016 20:30:41 -0700
Subject: [PATCH 1/2] Update Math.js to fix Issue 256

The fix to this issue is the same as the fix to Issue 244: if the result is out of range, try again.  The function was restructured to invoke `internalRandomGenerator` at only one location after the function's parameters' values have been set.  The test for the degenerate case where `a===b` and the not-so-infinite retry loop remain intact.  The function's header comment was cleaned up and ill chosen words like "high", "low" and "top" were removed.  Similarly, neutral variable names replaced those with "min" and "max".
---
 src/P5Functions/Math.js | 49 ++++++++++++++++++++++-------------------
 1 file changed, 26 insertions(+), 23 deletions(-)

diff --git a/src/P5Functions/Math.js b/src/P5Functions/Math.js
index ae9d96292..06db4f467 100755
--- a/src/P5Functions/Math.js
+++ b/src/P5Functions/Math.js
@@ -411,14 +411,14 @@ module.exports = function withMath(p, undef) {
 
   /**
   * Generates random numbers. Each time the random() function is called, it returns an unexpected value within
-  * the specified range. If one parameter is passed to the function it will return a float between zero and the
-  * value of the high parameter. The function call random(5) returns values between 0 and 5 (starting at zero,
+  * the specified range. If one parameter is passed to the function it will return a float between zero and
+  * that value. The function call random(5) returns values between 0 and 5 (starting at zero,
   * up to but not including 5). If two parameters are passed, it will return a float with a value between the
   * parameters. The function call random(-5, 10.2) returns values starting at -5 up to (but not including) 10.2.
   * To convert a floating-point random number to an integer, use the int() function.
   *
-  * @param {int|float} value1         if one parameter is used, the top end to random from, if two params the low end
-  * @param {int|float} value2         the top end of the random range
+  * @param {int|float} value1         if one parameter is used, the end of the range, if two params the beginning
+  * @param {int|float} value2         the end of the random range
   *
   * @returns {float}
   *
@@ -426,25 +426,28 @@ module.exports = function withMath(p, undef) {
   * @see noise
   */
   p.random = function() {
-    if(arguments.length === 0) {
-      return internalRandomGenerator();
-    }
-    if(arguments.length === 1) {
-      return internalRandomGenerator() * arguments[0];
-    }
-    var aMin = arguments[0], aMax = arguments[1];
-    if (aMin === aMax) {
-      return aMin;
-    }
-    for (var i = 0; i < 100; i++) {
-      var ir = internalRandomGenerator();
-      var result = ir * (aMax - aMin) + aMin;
-      if (result !== aMax) {
-        return result;
-      }
-      // assertion: ir is never less than 0.5
-    }
-    return aMin;
+    var a, b; // range from a to b
+  	if (arguments.length === 0) {
+  		a = 0;
+  		b = 1;
+  	} else if (arguments.length === 1) {
+  		a = 0;
+  		b = arguments[0];
+  	} else {
+  		a = arguments[0];
+  		b = arguments[1];
+  	}
+  	if (a !== b) {
+  		for (var i = 0; i < 100; i++) {
+  			var ir = internalRandomGenerator();
+  			var results = ir * (b - a) + a;
+  			if (results !== b) {
+  				return results;
+  			}
+  			// assertion: ir is never less than 0.5
+  		}
+  	}
+  	return a;
   };
 
   // Pseudo-random generator

From a4352a8cae3b075fbb89570c3e103c33a4dd7d8f Mon Sep 17 00:00:00 2001
From: Bob Lyon <Robert.B.Lyon@gmail.com>
Date: Mon, 1 Aug 2016 15:00:47 -0700
Subject: [PATCH 2/2] Incorporate  Pomax's feedback

Spaces, not tabs.
Explicit declaration of parameters, though there is no escaping the referencing of arguments.length.
---
 src/P5Functions/Math.js | 42 +++++++++++++++++++----------------------
 1 file changed, 19 insertions(+), 23 deletions(-)

diff --git a/src/P5Functions/Math.js b/src/P5Functions/Math.js
index 06db4f467..9f4da14bd 100755
--- a/src/P5Functions/Math.js
+++ b/src/P5Functions/Math.js
@@ -425,29 +425,25 @@ module.exports = function withMath(p, undef) {
   * @see randomSeed
   * @see noise
   */
-  p.random = function() {
-    var a, b; // range from a to b
-  	if (arguments.length === 0) {
-  		a = 0;
-  		b = 1;
-  	} else if (arguments.length === 1) {
-  		a = 0;
-  		b = arguments[0];
-  	} else {
-  		a = arguments[0];
-  		b = arguments[1];
-  	}
-  	if (a !== b) {
-  		for (var i = 0; i < 100; i++) {
-  			var ir = internalRandomGenerator();
-  			var results = ir * (b - a) + a;
-  			if (results !== b) {
-  				return results;
-  			}
-  			// assertion: ir is never less than 0.5
-  		}
-  	}
-  	return a;
+  p.random = function(a, b) {
+    a = a || 0;
+    if (arguments.length === 0) {
+      b = 1;
+    } else if (arguments.length === 1) {
+      b = a;
+      a = 0;
+    }
+    if (a !== b) {
+      for (var i = 0; i < 100; i++) {
+        var ir = internalRandomGenerator();
+        var results = ir * (b - a) + a;
+        if (results !== b) {
+          return results;
+        }
+        // assertion: ir is never less than 0.5
+      }
+    }
+    return a;
   };
 
   // Pseudo-random generator