Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 6006b3c

Browse files
carlosthe19916carlosthe19916
committed
feat(improve architecture): change classes names and packages
1 parent 30f0a0f commit 6006b3c

10 files changed

Lines changed: 134 additions & 32 deletions

File tree

‎README.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ PRODUCCIÓN | URL
3232
**Consulta CDR** | https://e-factura.sunat.gob.pe/ol-it-wsconscpegem/billConsultService
3333

3434
# Enviar Comprobantes de Pago mediante BillService
35-
Para enviar Boletas, Facturas, Notas de Crédito, Notas de Débito, Guias de Remisión, Percepciones, Retenciones se debe de usar la clase BillServiceSender.
35+
Para enviar Boletas, Facturas, Notas de Crédito, Notas de Débito, Guias de Remisión, Percepciones, Retenciones se debe de usar la clase BillServiceManager.
3636

3737
El valor de URL dependerá de qué tipo de documento está intentando enviar.
3838
```
@@ -41,11 +41,11 @@ USERNAME = "12345678959MODDATOS"; // RUC + USUARIO SOL
4141
PASSWORD = "MODDATOS"; // PASSWORD SOL
4242
4343
File file = new File(".../myFolder/12345678959-01-F001-00000001.xml");
44-
byte[] result = BillServiceSender.sendBill(file, URL, USERNAME, PASSWORD);
44+
byte[] result = BillServiceManager.sendBill(file, URL, USERNAME, PASSWORD);
4545
```
4646

4747
# Enviar Resumenes diarios y Bajas mediante BillService
48-
Para Enviar Resumenes diarios y Bajas se debe de usar la clase BillServiceSender.
48+
Para Enviar Resumenes diarios y Bajas se debe de usar la clase BillServiceManager.
4949

5050
```
5151
String URL = "https://e-beta.sunat.gob.pe/ol-ti-itcpfegem-beta/billService";
@@ -54,5 +54,5 @@ PASSWORD = "MODDATOS"; // PASSWORD SOL
5454
5555
File file = new File(".../myFolder/12345678959-RA-20180316-00001.xml");
5656
57-
String ticket = BillServiceSender.sendSummary(file, URL, USERNAME, PASSWORD);
57+
String ticket = BillServiceManager.sendSummary(file, URL, USERNAME, PASSWORD);
5858
```

src/main/java/io/github/carlosthe19916/webservices/cxf/ws/ServiceFactory.java renamed to src/main/java/io/github/carlosthe19916/webservices/factories/ServiceFactory.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,10 @@
1-
package io.github.carlosthe19916.webservices.cxf.ws;
1+
package io.github.carlosthe19916.webservices.factories;
22

3-
import io.github.carlosthe19916.webservices.cxf.ServiceConfig;
3+
import io.github.carlosthe19916.webservices.wrappers.ServiceConfig;
44
import org.apache.cxf.configuration.jsse.TLSClientParameters;
55
import org.apache.cxf.endpoint.Client;
66
import org.apache.cxf.endpoint.Endpoint;
77
import org.apache.cxf.frontend.ClientProxy;
8-
import org.apache.cxf.interceptor.LoggingInInterceptor;
9-
import org.apache.cxf.interceptor.LoggingOutInterceptor;
108
import org.apache.cxf.jaxws.JaxWsProxyFactoryBean;
119
import org.apache.cxf.transport.http.HTTPConduit;
1210
import org.apache.cxf.transports.http.configuration.HTTPClientPolicy;

src/main/java/io/github/carlosthe19916/webservices/cxf/ws/ServicePasswordCallback.java renamed to src/main/java/io/github/carlosthe19916/webservices/factories/ServicePasswordCallback.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package io.github.carlosthe19916.webservices.cxf.ws;
1+
package io.github.carlosthe19916.webservices.factories;
22

33
import org.apache.wss4j.common.ext.WSPasswordCallback;
44

‎src/main/java/io/github/carlosthe19916/webservices/managers/BillConsultBean.java‎

Lines changed: 63 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,63 @@
1+
package io.github.carlosthe19916.webservices.managers;
2+
3+
public class BillConsultBean {
4+
5+
private final String ruc;
6+
private final String tipo;
7+
private final String serie;
8+
private final int numero;
9+
10+
private BillConsultBean(Builder builder) {
11+
this.ruc = builder.ruc;
12+
this.tipo = builder.tipo;
13+
this.serie = builder.serie;
14+
this.numero = builder.numero;
15+
}
16+
17+
public String getRuc() {
18+
return ruc;
19+
}
20+
21+
public String getTipo() {
22+
return tipo;
23+
}
24+
25+
public String getSerie() {
26+
return serie;
27+
}
28+
29+
public int getNumero() {
30+
return numero;
31+
}
32+
33+
public static class Builder {
34+
private String ruc;
35+
private String tipo;
36+
private String serie;
37+
private Integer numero;
38+
39+
public Builder ruc(String ruc) {
40+
this.ruc = ruc;
41+
return this;
42+
}
43+
44+
public Builder tipo(String tipo) {
45+
this.tipo = tipo;
46+
return this;
47+
}
48+
49+
public Builder serie(String serie) {
50+
this.serie = serie;
51+
return this;
52+
}
53+
54+
public Builder numero(int numero) {
55+
this.numero = numero;
56+
return this;
57+
}
58+
59+
public BillConsultBean build() {
60+
return new BillConsultBean(this);
61+
}
62+
}
63+
}

‎src/main/java/io/github/carlosthe19916/webservices/managers/BillConsultServiceManager.java‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
package io.github.carlosthe19916.webservices.managers;
2+
3+
import io.github.carlosthe19916.webservices.wrappers.BillConsultServiceWrapper;
4+
import io.github.carlosthe19916.webservices.wrappers.ServiceConfig;
5+
6+
public class BillConsultServiceManager {
7+
8+
private BillConsultServiceManager() {
9+
// Just static methods
10+
}
11+
12+
public static service.sunat.gob.pe.billconsultservice.StatusResponse getStatus(ServiceConfig config, BillConsultBean consulta) {
13+
return BillConsultServiceWrapper.getStatus(config, consulta.getRuc(), consulta.getTipo(), consulta.getSerie(), consulta.getNumero());
14+
}
15+
16+
public static service.sunat.gob.pe.billconsultservice.StatusResponse getStatusCdr(ServiceConfig config, BillConsultBean consulta) {
17+
return BillConsultServiceWrapper.getStatusCdr(config, consulta.getRuc(), consulta.getTipo(), consulta.getSerie(), consulta.getNumero());
18+
}
19+
20+
}

src/main/java/io/github/carlosthe19916/webservices/BillServiceSender.java renamed to src/main/java/io/github/carlosthe19916/webservices/managers/BillServiceManager.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
package io.github.carlosthe19916.webservices;
1+
package io.github.carlosthe19916.webservices.managers;
22

3-
import io.github.carlosthe19916.webservices.cxf.BillServiceManager;
4-
import io.github.carlosthe19916.webservices.cxf.ServiceConfig;
3+
import io.github.carlosthe19916.webservices.wrappers.BillServiceWrapper;
4+
import io.github.carlosthe19916.webservices.wrappers.ServiceConfig;
55
import jodd.io.ZipBuilder;
66
import service.sunat.gob.pe.billservice.StatusResponse;
77

@@ -10,9 +10,9 @@
1010
import java.nio.file.Files;
1111
import java.nio.file.Path;
1212

13-
public class BillServiceSender {
13+
public class BillServiceManager {
1414

15-
private BillServiceSender() {
15+
private BillServiceManager() {
1616
// Just static methods
1717
}
1818

@@ -58,7 +58,7 @@ public static byte[] sendBill(String fileName, byte[] file, String url, String u
5858
.username(username)
5959
.passwod(password)
6060
.build();
61-
return BillServiceManager.sendBill(config, fileName, file, null);
61+
return BillServiceWrapper.sendBill(config, fileName, file, null);
6262
}
6363

6464
/**
@@ -73,7 +73,7 @@ public static StatusResponse getStatus(String ticket, String url, String usernam
7373
.username(username)
7474
.passwod(password)
7575
.build();
76-
return BillServiceManager.getStatus(config, ticket);
76+
return BillServiceWrapper.getStatus(config, ticket);
7777
}
7878

7979
/**
@@ -118,7 +118,7 @@ public static String sendSummary(String fileName, byte[] file, String url, Strin
118118
.username(username)
119119
.passwod(password)
120120
.build();
121-
return BillServiceManager.sendSummary(config, fileName, file, null);
121+
return BillServiceWrapper.sendSummary(config, fileName, file, null);
122122
}
123123

124124
/**
@@ -154,7 +154,7 @@ public static String sendPack(String fileName, byte[] file, String url, String u
154154
.username(username)
155155
.passwod(password)
156156
.build();
157-
return BillServiceManager.sendPack(config, fileName, file, null);
157+
return BillServiceWrapper.sendPack(config, fileName, file, null);
158158
}
159159

160160
}

‎src/main/java/io/github/carlosthe19916/webservices/wrappers/BillConsultServiceWrapper.java‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
package io.github.carlosthe19916.webservices.wrappers;
2+
3+
import io.github.carlosthe19916.webservices.factories.ServiceFactory;
4+
5+
public class BillConsultServiceWrapper {
6+
7+
private BillConsultServiceWrapper() {
8+
// Just static methods
9+
}
10+
11+
public static service.sunat.gob.pe.billconsultservice.StatusResponse getStatus(ServiceConfig config, String ruc, String tipo, String serie, int numero) {
12+
service.sunat.gob.pe.billconsultservice.BillService billService = ServiceFactory.getInstance(service.sunat.gob.pe.billconsultservice.BillService.class, config);
13+
return billService.getStatus(ruc, tipo, serie, numero);
14+
}
15+
16+
public static service.sunat.gob.pe.billconsultservice.StatusResponse getStatusCdr(ServiceConfig config, String ruc, String tipo, String serie, int numero) {
17+
service.sunat.gob.pe.billconsultservice.BillService billService = ServiceFactory.getInstance(service.sunat.gob.pe.billconsultservice.BillService.class, config);
18+
return billService.getStatus(ruc, tipo, serie, numero);
19+
}
20+
21+
}

src/main/java/io/github/carlosthe19916/webservices/cxf/BillServiceManager.java renamed to src/main/java/io/github/carlosthe19916/webservices/wrappers/BillServiceWrapper.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
1-
package io.github.carlosthe19916.webservices.cxf;
1+
package io.github.carlosthe19916.webservices.wrappers;
22

3-
import io.github.carlosthe19916.webservices.cxf.ws.ServiceFactory;
3+
import io.github.carlosthe19916.webservices.factories.ServiceFactory;
44

55
import javax.activation.DataHandler;
66
import javax.activation.DataSource;
77
import javax.mail.util.ByteArrayDataSource;
88

9-
public class BillServiceManager {
9+
public class BillServiceWrapper {
1010

11-
private BillServiceManager() {
11+
private BillServiceWrapper() {
1212
// Just static methods
1313
}
1414

src/main/java/io/github/carlosthe19916/webservices/cxf/ServiceConfig.java renamed to src/main/java/io/github/carlosthe19916/webservices/wrappers/ServiceConfig.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package io.github.carlosthe19916.webservices.cxf;
1+
package io.github.carlosthe19916.webservices.wrappers;
22

33
public class ServiceConfig {
44

src/test/java/io/github/carlosthe19916/webservices/BillServiceSenderTest.java renamed to src/test/java/io/github/carlosthe19916/webservices/managers/BillServiceManagerTest.java

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package io.github.carlosthe19916.webservices;
1+
package io.github.carlosthe19916.webservices.managers;
22

33

44
import org.junit.Assert;
@@ -12,7 +12,7 @@
1212
import java.nio.file.Path;
1313
import java.nio.file.Paths;
1414

15-
public class BillServiceSenderTest {
15+
public class BillServiceManagerTest {
1616

1717
private String USERNAME = "20494637074MODDATOS";
1818
private String PASSWORD = "MODDATOS";
@@ -27,7 +27,7 @@ public void sendBillInvoiceXml() throws IOException {
2727
byte[] bytes = new byte[is.available()];
2828
int read = is.read(bytes);
2929

30-
byte[] result = BillServiceSender.sendBill(FILE_NAME, bytes, URL_BOLETA_FACTURA, USERNAME, PASSWORD);
30+
byte[] result = BillServiceManager.sendBill(FILE_NAME, bytes, URL_BOLETA_FACTURA, USERNAME, PASSWORD);
3131
Assert.assertNotNull(result);
3232
}
3333

@@ -37,7 +37,7 @@ public void sendBillInvoicePath() throws IOException, URISyntaxException {
3737
java.net.URL url = getClass().getResource("/ubl/" + FILE_NAME);
3838
Path path = Paths.get(url.toURI());
3939

40-
byte[] result = BillServiceSender.sendBill(path, URL_BOLETA_FACTURA, USERNAME, PASSWORD);
40+
byte[] result = BillServiceManager.sendBill(path, URL_BOLETA_FACTURA, USERNAME, PASSWORD);
4141
Assert.assertNotNull(result);
4242
}
4343

@@ -48,7 +48,7 @@ public void sendBillInvoiceFile() throws IOException, URISyntaxException {
4848
Path path = Paths.get(url.toURI());
4949
File file = path.toFile();
5050

51-
byte[] result = BillServiceSender.sendBill(file, URL_BOLETA_FACTURA, USERNAME, PASSWORD);
51+
byte[] result = BillServiceManager.sendBill(file, URL_BOLETA_FACTURA, USERNAME, PASSWORD);
5252
Assert.assertNotNull(result);
5353
}
5454

@@ -60,15 +60,15 @@ public void sendBillRetencionXml() throws IOException {
6060
byte[] bytes = new byte[is.available()];
6161
int read = is.read(bytes);
6262

63-
byte[] result = BillServiceSender.sendBill(FILE_NAME, bytes, URL_RETENCION, USERNAME, PASSWORD);
63+
byte[] result = BillServiceManager.sendBill(FILE_NAME, bytes, URL_RETENCION, USERNAME, PASSWORD);
6464
Assert.assertNotNull(result);
6565
}
6666

6767
@Test
6868
public void getStatus() {
6969
final String TICKET = "1529342625179";
7070

71-
StatusResponse status = BillServiceSender.getStatus(TICKET, URL_BOLETA_FACTURA, USERNAME, PASSWORD);
71+
StatusResponse status = BillServiceManager.getStatus(TICKET, URL_BOLETA_FACTURA, USERNAME, PASSWORD);
7272
Assert.assertNotNull(status);
7373
}
7474

@@ -80,7 +80,7 @@ public void sendInvoiceVoidedDocumentXml() throws IOException {
8080
byte[] bytes = new byte[is.available()];
8181
int read = is.read(bytes);
8282

83-
String ticket = BillServiceSender.sendSummary(FILE_NAME, bytes, URL_BOLETA_FACTURA, USERNAME, PASSWORD);
83+
String ticket = BillServiceManager.sendSummary(FILE_NAME, bytes, URL_BOLETA_FACTURA, USERNAME, PASSWORD);
8484
Assert.assertNotNull(ticket);
8585
}
8686

@@ -92,7 +92,7 @@ public void sendRetencionVoidedDocumentXml() throws IOException {
9292
byte[] bytes = new byte[is.available()];
9393
int read = is.read(bytes);
9494

95-
String ticket = BillServiceSender.sendSummary(FILE_NAME, bytes, URL_RETENCION, USERNAME, PASSWORD);
95+
String ticket = BillServiceManager.sendSummary(FILE_NAME, bytes, URL_RETENCION, USERNAME, PASSWORD);
9696
Assert.assertNotNull(ticket);
9797
}
9898

0 commit comments

Comments
 (0)