[ObjC] Remove -[GPBFieldDescriptor optional]

thomasvl · copybara-github · commit 3414dc151eb4 · 2025-10-06T09:57:49.000-07:00
As announced: https://protobuf.dev/news/2025-09-19/#objc-remove-apis Removing the deprecated api as part of the ObjC Major Version bump coming in 2026Q1. PiperOrigin-RevId: 815768697
diff --git a/objectivec/GPBDescriptor.h b/objectivec/GPBDescriptor.h
@@ -172,9 +172,6 @@ __attribute__((objc_subclassing_restricted))
 @property(nonatomic, readonly) GPBGenericValue defaultValue;
 /** Whether this field is required. Only valid for proto2 fields. */
 @property(nonatomic, readonly, getter=isRequired) BOOL required;
-/** Whether this field is optional. */
-@property(nonatomic, readonly, getter=isOptional) BOOL optional DEPRECATED_MSG_ATTRIBUTE(
-    "Check if fieldType is GPBFieldTypeSingle and that it is NOT required.");
 /** Type of field (single, repeated, map). */
 @property(nonatomic, readonly) GPBFieldType fieldType;
 /** Type of the key if the field is a map. The value's type is -dataType. */
diff --git a/objectivec/GPBDescriptor.m b/objectivec/GPBDescriptor.m
@@ -630,13 +630,6 @@ - (BOOL)isRequired {
   return (description_->flags & GPBFieldRequired) != 0;
 }
 
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-implementations"
-- (BOOL)isOptional {
-  return self.fieldType == GPBFieldTypeSingle && !self.isRequired;
-}
-#pragma clang diagnostic pop
-
 - (GPBFieldType)fieldType {
   GPBFieldFlags flags = description_->flags;
   if ((flags & GPBFieldRepeated) != 0) {
