portmidi: directly use Pm_Read in the while loop

Spacechild1 · Spacechild1 · commit bf323c88e843 · 2019-04-29T23:24:19.000+02:00
the call to Pm_Poll before Pm_Read is redundant and caused problems because it doesn't report overflow errors!
(so once an overflow occured sys_poll_midi would stop reading)
diff --git a/src/s_midi_pm.c b/src/s_midi_pm.c
@@ -273,11 +273,10 @@ void sys_poll_midi(void)
     PmEvent buffer;
     for (i = 0; i < mac_nmidiindev; i++)
     {
-        while(Pm_Poll(mac_midiindevlist[i]))
+        while((nmess = Pm_Read(mac_midiindevlist[i], &buffer, 1)))
         {
             if (!throttle--)
                 goto overload;
-            nmess = Pm_Read(mac_midiindevlist[i], &buffer, 1);
             if (nmess > 0)
             {
                 int status = Pm_MessageStatus(buffer.message);
@@ -328,7 +327,7 @@ void sys_poll_midi(void)
             }
             else
             {
-                error("portmidi: %s", Pm_GetErrorText(nmess));
+                error("%s", Pm_GetErrorText(nmess));
                 if (nmess != pmBufferOverflow)
                     break;
             }

Original file line number	Diff line number	Diff line change
`@@ -273,11 +273,10 @@ void sys_poll_midi(void)`
`273`	`273`	`PmEvent buffer;`
`274`	`274`	`for (i = 0; i < mac_nmidiindev; i++)`
`275`	`275`	`{`
`276`		`- while(Pm_Poll(mac_midiindevlist[i]))`
	`276`	`+ while((nmess = Pm_Read(mac_midiindevlist[i], &buffer, 1)))`
`277`	`277`	`{`
`278`	`278`	`if (!throttle--)`
`279`	`279`	`goto overload;`
`280`		`- nmess = Pm_Read(mac_midiindevlist[i], &buffer, 1);`
`281`	`280`	`if (nmess > 0)`
`282`	`281`	`{`
`283`	`282`	`int status = Pm_MessageStatus(buffer.message);`
`@@ -328,7 +327,7 @@ void sys_poll_midi(void)`
`328`	`327`	`}`
`329`	`328`	`else`
`330`	`329`	`{`
`331`		`- error("portmidi: %s", Pm_GetErrorText(nmess));`
	`330`	`+ error("%s", Pm_GetErrorText(nmess));`
`332`	`331`	`if (nmess != pmBufferOverflow)`
`333`	`332`	`break;`
`334`	`333`	`}`