fix: Update database fake to check for nil time when streaming logs (coder#2664)

kylecarbs · web-flow · commit 95e854d144d1 · 2022-06-26T19:52:15.000Z
This caused a test flake seen here: https://github.com/coder/coder/runs/7056544834?check_suite_focus=true
diff --git a/coderd/database/databasefake/databasefake.go b/coderd/database/databasefake/databasefake.go
@@ -1360,10 +1360,10 @@ func (q *fakeQuerier) GetProvisionerLogsByIDBetween(_ context.Context, arg datab
 		if jobLog.JobID.String() != arg.JobID.String() {
 			continue
 		}
-		if jobLog.CreatedAt.After(arg.CreatedBefore) {
+		if !arg.CreatedBefore.IsZero() && jobLog.CreatedAt.After(arg.CreatedBefore) {
 			continue
 		}
-		if jobLog.CreatedAt.Before(arg.CreatedAfter) {
+		if !arg.CreatedAfter.IsZero() && jobLog.CreatedAt.Before(arg.CreatedAfter) {
 			continue
 		}
 		logs = append(logs, jobLog)

Original file line number	Diff line number	Diff line change
`@@ -1360,10 +1360,10 @@ func (q *fakeQuerier) GetProvisionerLogsByIDBetween(_ context.Context, arg datab`
`1360`	`1360`	`if jobLog.JobID.String() != arg.JobID.String() {`
`1361`	`1361`	`continue`
`1362`	`1362`	`}`
`1363`		`- if jobLog.CreatedAt.After(arg.CreatedBefore) {`
	`1363`	`+ if !arg.CreatedBefore.IsZero() && jobLog.CreatedAt.After(arg.CreatedBefore) {`
`1364`	`1364`	`continue`
`1365`	`1365`	`}`
`1366`		`- if jobLog.CreatedAt.Before(arg.CreatedAfter) {`
	`1366`	`+ if !arg.CreatedAfter.IsZero() && jobLog.CreatedAt.Before(arg.CreatedAfter) {`
`1367`	`1367`	`continue`
`1368`	`1368`	`}`
`1369`	`1369`	`logs = append(logs, jobLog)`