Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Changing labels when a review gets requested #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lysnikolaou opened this issue Apr 24, 2020 · 3 comments
Closed

Changing labels when a review gets requested #219

lysnikolaou opened this issue Apr 24, 2020 · 3 comments

Comments

@lysnikolaou
Copy link
Member

While working on python/cpython#19694, I found out that labels don't change, if a PR has been approved and the author requests a review once more.

I think it would be a good idea to change the label back to awaiting core review, when a review gets requested. Thoughts?
@brettcannon
Copy link
Member

Seems reasonable. I know @vstinner has been worried about changes made post-approval when auto-merge is turned on. Maybe it's worth resetting the reviews as well?

@Mariatta
Copy link
Member

Related issue: python/core-workflow#325

@Mariatta
Copy link
Member

This has been addressed in #220. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@brettcannon @Mariatta @lysnikolaou