-
-
Notifications
You must be signed in to change notification settings - Fork 60
Incorrect bedevere transition (the sequel) #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
In my mind, moving a PR to draft and then back to published is equivalent to submitting a new PR (under the unfounded assumption that you move to draft only if you want to significantly rework the PR). |
For me, that's an incorrect assumption ;) It's not unusual for me to do testing locally, think I've got a strong PR, file it on GitHub... then get cold feet, so I'll put it back into draft while I do some more testing locally, just in case somebody else merges it while I'm doing more testing. But then my local testing proves my fears were incorrect, so I move it out of draft again without having changed much at all! |
In general, I agree with Itamar. But if the commit hasn't changed since it was approved, and if it's easy to check that, I think would be nice to go straight back to "awaiting merge" |
I'm sure it could be done with a bunch of additional labels. I don't know if this would be considered easy (or desirable) :) |
More labels sounds like a bad idea! I found the sequence in python/cpython#104559 surprising, but it sounds like I might be in the minority (and it's not a huge issue, anyway), so better to do nothing here than add loads more complexity, I think :) |
Let's not add more labels. In my mind if a PR already has awaiting merge label, we should not move it back to draft. You could add the "do not merge" label if you still need to work on it more. So I think the behavior that's currently implemented is correct. |
It looks like there's still a few situations that confuse Bedevere when trying to figure out which labels to add or remove.
In python/cpython#104559:
Cc. @itamaro :)
The text was updated successfully, but these errors were encountered: