Issue #11006: Don't issue low level warning in subprocess when pipe2() fails.

rosslagerwall · rosslagerwall · commit 031bf95d3212 · 2011-12-22T09:07:30.000+02:00
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -97,6 +97,8 @@ Core and Builtins
 Library
 -------
 
+- Issue #11006: Don't issue low level warning in subprocess when pipe2() fails.
+
 - Issue #11829: Fix code execution holes in inspect.getattr_static for
   metaclasses with metaclasses. Patch by Andreas Stührk.
 
diff --git a/Modules/_posixsubprocess.c b/Modules/_posixsubprocess.c
@@ -437,12 +437,6 @@ subprocess_cloexec_pipe(PyObject *self, PyObject *noargs)
     Py_END_ALLOW_THREADS
     if (res != 0 && errno == ENOSYS)
     {
-        if (PyErr_WarnEx(
-                PyExc_RuntimeWarning,
-                "pipe2 set errno ENOSYS; falling "
-                "back to non-atomic pipe+fcntl.", 1) != 0) {
-            return NULL;
-        }
         {
 #endif
         /* We hold the GIL which offers some protection from other code calling

Original file line number	Diff line number	Diff line change
`@@ -437,12 +437,6 @@ subprocess_cloexec_pipe(PyObject self, PyObject noargs)`
`437`	`437`	`Py_END_ALLOW_THREADS`
`438`	`438`	`if (res != 0 && errno == ENOSYS)`
`439`	`439`	`{`
`440`		`- if (PyErr_WarnEx(`
`441`		`- PyExc_RuntimeWarning,`
`442`		`- "pipe2 set errno ENOSYS; falling "`
`443`		`- "back to non-atomic pipe+fcntl.", 1) != 0) {`
`444`		`- return NULL;`
`445`		`- }`
`446`	`440`	`{`
`447`	`441`	`#endif`
`448`	`442`	`/* We hold the GIL which offers some protection from other code calling`