Issue #18408: Fix listpop(), handle list_ass_slice() failure

vstinner · vstinner · commit 095d99ffffbc · 2013-07-17T21:58:01.000+02:00
diff --git a/Objects/listobject.c b/Objects/listobject.c
@@ -934,12 +934,10 @@ listpop(PyListObject *self, PyObject *args)
     }
     Py_INCREF(v);
     status = list_ass_slice(self, i, i+1, (PyObject *)NULL);
-    assert(status >= 0);
-    /* Use status, so that in a release build compilers don't
-     * complain about the unused name.
-     */
-    (void) status;
-
+    if (status < 0) {
+        Py_DECREF(v);
+        return NULL;
+    }
     return v;
 }
 
