bpo-31234: Try to fix lock_tests warning (#3557)

vstinner · web-flow · commit 096ae3373aba · 2017-09-13T16:41:08.000-07:00
Try to fix the "Warning -- threading_cleanup() failed to cleanup 1
threads" warning in test.lock_tests: wait a little bit longer to give
time to the threads to complete.

Warning seen on test_thread and test_importlib.
diff --git a/Lib/test/lock_tests.py b/Lib/test/lock_tests.py
@@ -54,6 +54,13 @@ def wait_for_started(self):
     def wait_for_finished(self):
         while len(self.finished) < self.n:
             _wait()
+        # Wait a little bit longer to prevent the "threading_cleanup()
+        # failed to cleanup X threads" warning. The loop above is a weak
+        # synchronization. At the C level, t_bootstrap() can still be
+        # running and so _thread.count() still accounts the "almost dead"
+        # thead.
+        for _ in range(self.n):
+            _wait()
 
     def do_finish(self):
         self._can_exit = True
@@ -304,6 +311,7 @@ def f():
             self.assertRaises(RuntimeError, lock.release)
         finally:
             b.do_finish()
+        b.wait_for_finished()
 
     def test__is_owned(self):
         lock = self.locktype()
