Add stats for marking

markshannon · markshannon · commit 0b46494423ba · 2024-11-21T16:19:20.000Z
diff --git a/Python/specialize.c b/Python/specialize.c
@@ -231,6 +231,8 @@ print_gc_stats(FILE *out, GCStats *stats)
         fprintf(out, "GC[%d] collections: %" PRIu64 "\n", i, stats[i].collections);
         fprintf(out, "GC[%d] object visits: %" PRIu64 "\n", i, stats[i].object_visits);
         fprintf(out, "GC[%d] objects collected: %" PRIu64 "\n", i, stats[i].objects_collected);
+        fprintf(out, "GC[%d] objects reachable from roots: %" PRIu64 "\n", i, stats[i].objects_transitively_reachable);
+        fprintf(out, "GC[%d] objects not reachable from roots: %" PRIu64 "\n", i, stats[i].objects_not_transitively_reachable);
     }
 }
 
diff --git a/Tools/scripts/summarize_stats.py b/Tools/scripts/summarize_stats.py
@@ -1118,6 +1118,8 @@ def calc_gc_stats(stats: Stats) -> Rows:
                 Count(gen["collections"]),
                 Count(gen["objects collected"]),
                 Count(gen["object visits"]),
+                Count(gen["objects reachable from roots"]),
+                Count(gen["objects not reachable from roots"]),
             )
             for (i, gen) in enumerate(gc_stats)
         ]
@@ -1127,7 +1129,8 @@ def calc_gc_stats(stats: Stats) -> Rows:
         "GC collections and effectiveness",
         [
             Table(
-                ("Generation:", "Collections:", "Objects collected:", "Object visits:"),
+                ("Generation:", "Collections:", "Objects collected:", "Object visits:",
+                 "Reachable from roots:", "Not reachable from roots:"),
                 calc_gc_stats,
             )
         ],

Original file line number	Diff line number	Diff line change
`@@ -231,6 +231,8 @@ print_gc_stats(FILE out, GCStats stats)`
`231`	`231`	`fprintf(out, "GC[%d] collections: %" PRIu64 "\n", i, stats[i].collections);`
`232`	`232`	`fprintf(out, "GC[%d] object visits: %" PRIu64 "\n", i, stats[i].object_visits);`
`233`	`233`	`fprintf(out, "GC[%d] objects collected: %" PRIu64 "\n", i, stats[i].objects_collected);`
	`234`	`+ fprintf(out, "GC[%d] objects reachable from roots: %" PRIu64 "\n", i, stats[i].objects_transitively_reachable);`
	`235`	`+ fprintf(out, "GC[%d] objects not reachable from roots: %" PRIu64 "\n", i, stats[i].objects_not_transitively_reachable);`
`234`	`236`	`}`
`235`	`237`	`}`
`236`	`238`
Original file line number	Diff line number	Diff line change
`@@ -1118,6 +1118,8 @@ def calc_gc_stats(stats: Stats) -> Rows:`
`1118`	`1118`	`Count(gen["collections"]),`
`1119`	`1119`	`Count(gen["objects collected"]),`
`1120`	`1120`	`Count(gen["object visits"]),`
	`1121`	`+ Count(gen["objects reachable from roots"]),`
	`1122`	`+ Count(gen["objects not reachable from roots"]),`
`1121`	`1123`	`)`
`1122`	`1124`	`for (i, gen) in enumerate(gc_stats)`
`1123`	`1125`	`]`
`@@ -1127,7 +1129,8 @@ def calc_gc_stats(stats: Stats) -> Rows:`
`1127`	`1129`	`"GC collections and effectiveness",`
`1128`	`1130`	`[`
`1129`	`1131`	`Table(`
`1130`		`- ("Generation:", "Collections:", "Objects collected:", "Object visits:"),`
	`1132`	`+ ("Generation:", "Collections:", "Objects collected:", "Object visits:",`
	`1133`	`+ "Reachable from roots:", "Not reachable from roots:"),`
`1131`	`1134`	`calc_gc_stats,`
`1132`	`1135`	`)`
`1133`	`1136`	`],`