Protect PyErr_Format format string argument from overflow (ironically,

gvanrossum · gvanrossum · commit 0d6b49eff2ba · 1998-01-19T22:22:44.000Z
the error was about a bad format string :-).
diff --git a/Python/getargs.c b/Python/getargs.c
@@ -261,7 +261,7 @@ vgetargs1(args, format, p_va, compat)
 	    *format != '(' &&
 	    *format != '|' && *format != ':' && *format != ';') {
 		PyErr_Format(PyExc_SystemError,
-			     "bad format string: %s", formatsave);
+			     "bad format string: %.200s", formatsave);
 		return 0;
 	}
 	

Original file line number	Diff line number	Diff line change
`@@ -261,7 +261,7 @@ vgetargs1(args, format, p_va, compat)`
`261`	`261`	`*format != '(' &&`
`262`	`262`	`format != '\|' && format != ':' && *format != ';') {`
`263`	`263`	`PyErr_Format(PyExc_SystemError,`
`264`		`- "bad format string: %s", formatsave);`
	`264`	`+ "bad format string: %.200s", formatsave);`
`265`	`265`	`return 0;`
`266`	`266`	`}`
`267`	`267`