Issue #18174: Fix fd leaks in tests.

shibturn · shibturn · commit 0e547b66dc20 · 2013-06-10T16:29:19.000+01:00
diff --git a/Lib/test/test_openpty.py b/Lib/test/test_openpty.py
@@ -10,6 +10,8 @@
 class OpenptyTest(unittest.TestCase):
     def test(self):
         master, slave = os.openpty()
+        self.addCleanup(os.close, master)
+        self.addCleanup(os.close, slave)
         if not os.isatty(slave):
             self.fail("Slave-end of pty is not a terminal.")
 
diff --git a/Lib/test/test_subprocess.py b/Lib/test/test_subprocess.py
@@ -1263,7 +1263,8 @@ def _execute_child(self, *args, **kwargs):
                                      self.stderr.fileno()),
                                 msg="At least one fd was closed early.")
                 finally:
-                    map(os.close, devzero_fds)
+                    for fd in devzero_fds:
+                        os.close(fd)
 
     @unittest.skipIf(not os.path.exists("/dev/zero"), "/dev/zero required.")
     def test_preexec_errpipe_does_not_double_close_pipes(self):
diff --git a/Lib/test/test_uuid.py b/Lib/test/test_uuid.py
@@ -458,6 +458,7 @@ def testIssue8621(self):
 
         else:
             os.close(fds[1])
+            self.addCleanup(os.close, fds[0])
             parent_value = uuid.uuid4().hex
             os.waitpid(pid, 0)
             child_value = os.read(fds[0], 100).decode('latin-1')
