Use proper plural forms in argparse (#4391)

merwok · merwok · commit 1215915045d6 · 2010-12-04T17:31:49.000Z
diff --git a/Lib/argparse.py b/Lib/argparse.py
@@ -88,7 +88,7 @@
 import sys as _sys
 import textwrap as _textwrap
 
-from gettext import gettext as _
+from gettext import gettext as _, ngettext
 
 
 def _callable(obj):
@@ -1438,7 +1438,9 @@ def _check_conflict(self, action):
             conflict_handler(action, confl_optionals)
 
     def _handle_conflict_error(self, action, conflicting_actions):
-        message = _('conflicting option string(s): %s')
+        message = ngettext('conflicting option string: %s',
+                           'conflicting option strings: %s',
+                           len(conflicting_actions))
         conflict_string = ', '.join([option_string
                                      for option_string, action
                                      in conflicting_actions])
@@ -1995,7 +1997,9 @@ def _match_argument(self, action, arg_strings_pattern):
                 OPTIONAL: _('expected at most one argument'),
                 ONE_OR_MORE: _('expected at least one argument'),
             }
-            default = _('expected %s argument(s)') % action.nargs
+            default = ngettext('expected %s argument',
+                               'expected %s arguments',
+                               action.nargs) % action.nargs
             msg = nargs_errors.get(action.nargs, default)
             raise ArgumentError(action, msg)
 
diff --git a/Lib/test/test_argparse.py b/Lib/test/test_argparse.py
@@ -4315,7 +4315,7 @@ def test_all_exports_everything_but_modules(self):
         items = [
             name
             for name, value in vars(argparse).items()
-            if not name.startswith("_")
+            if not (name.startswith("_") or name == 'ngettext')
             if not inspect.ismodule(value)
         ]
         self.assertEqual(sorted(items), sorted(argparse.__all__))
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -49,6 +49,8 @@ Core and Builtins
 Library
 -------
 
+- Issue #4391: Use proper plural forms in argparse.
+
 - Issue #10601: sys.displayhook uses 'backslashreplace' error handler on
   UnicodeEncodeError.
 

Original file line number	Diff line number	Diff line change
`@@ -4315,7 +4315,7 @@ def test_all_exports_everything_but_modules(self):`
`4315`	`4315`	`items = [`
`4316`	`4316`	`name`
`4317`	`4317`	`for name, value in vars(argparse).items()`
`4318`		`- if not name.startswith("_")`
	`4318`	`+ if not (name.startswith("_") or name == 'ngettext')`
`4319`	`4319`	`if not inspect.ismodule(value)`
`4320`	`4320`	`]`
`4321`	`4321`	`self.assertEqual(sorted(items), sorted(argparse.__all__))`