SF patch #491049 (David Jacobs): Small PyString_FromString optimization

gvanrossum · gvanrossum · commit 169192e8184f · 2001-12-10T15:45:54.000Z
PyString_FromString():
  Since the length of the string is already being stored in size,
  changed the strcpy() to a memcpy() for a small speed improvement.
diff --git a/Objects/stringobject.c b/Objects/stringobject.c
@@ -144,7 +144,7 @@ PyString_FromString(const char *str)
 #ifdef INTERN_STRINGS
 	op->ob_sinterned = NULL;
 #endif
-	strcpy(op->ob_sval, str);
+	memcpy(op->ob_sval, str, size+1);
 #ifndef DONT_SHARE_SHORT_STRINGS
 	if (size == 0) {
 		PyObject *t = (PyObject *)op;
