Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 17ace7a

Browse files
committed
Merge with 3.1
2 parents d8f2d50 + b8a5769 commit 17ace7a

3 files changed

Lines changed: 5 additions & 0 deletions

File tree

Lib/test/test_subprocess.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1226,6 +1226,7 @@ def test_select_unbuffered(self):
12261226
stdout=subprocess.PIPE,
12271227
bufsize=0)
12281228
f = p.stdout
1229+
self.addCleanup(f.close)
12291230
try:
12301231
self.assertEqual(f.read(4), b"appl")
12311232
self.assertIn(f, select.select([f], [], [], 0.0)[0])

Misc/ACKS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -354,6 +354,7 @@ Brian Harring
354354
Larry Hastings
355355
Shane Hathaway
356356
Rycharde Hawkes
357+
Ben Hayden
357358
Jochen Hayek
358359
Christian Heimes
359360
Thomas Heller

Misc/NEWS

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,9 @@ Core and Builtins
5353
Library
5454
-------
5555

56+
- Issue #11659: Fix ResourceWarning in test_subprocess introduced by #11459.
57+
Patch by Ben Hayden.
58+
5659
- Issue #11635: Don't use polling in worker threads and processes launched by
5760
concurrent.futures.
5861

0 commit comments

Comments
 (0)