Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 17f5f81

Browse files
Issue #15759: "make suspicious", "make linkcheck" and "make doctest" in Doc/
now display special message when and only when there are failures.
1 parent dfab935 commit 17f5f81

2 files changed

Lines changed: 19 additions & 10 deletions

File tree

Doc/Makefile

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -69,24 +69,30 @@ changes: build
6969
@echo "The overview file is in build/changes."
7070

7171
linkcheck: BUILDER = linkcheck
72-
linkcheck: build
73-
@echo "Link check complete; look for any errors in the above output" \
74-
"or in build/$(BUILDER)/output.txt"
72+
linkcheck:
73+
@$(MAKE) build BUILDER=$(BUILDER) || { \
74+
echo "Link check complete; look for any errors in the above output" \
75+
"or in build/$(BUILDER)/output.txt"; \
76+
false; }
7577

7678
suspicious: BUILDER = suspicious
77-
suspicious: build
78-
@echo "Suspicious check complete; look for any errors in the above output" \
79-
"or in build/$(BUILDER)/suspicious.csv. If all issues are false" \
80-
"positives, append that file to tools/sphinxext/susp-ignored.csv."
79+
suspicious:
80+
@$(MAKE) build BUILDER=$(BUILDER) || { \
81+
echo "Suspicious check complete; look for any errors in the above output" \
82+
"or in build/$(BUILDER)/suspicious.csv. If all issues are false" \
83+
"positives, append that file to tools/sphinxext/susp-ignored.csv."; \
84+
false; }
8185

8286
coverage: BUILDER = coverage
8387
coverage: build
8488
@echo "Coverage finished; see c.txt and python.txt in build/coverage"
8589

8690
doctest: BUILDER = doctest
87-
doctest: build
88-
@echo "Testing of doctests in the sources finished, look at the" \
89-
"results in build/doctest/output.txt"
91+
doctest:
92+
@$(MAKE) build BUILDER=$(BUILDER) || { \
93+
echo "Testing of doctests in the sources finished, look at the" \
94+
"results in build/doctest/output.txt"; \
95+
false; }
9096

9197
pydoc-topics: BUILDER = pydoc-topics
9298
pydoc-topics: build

Misc/NEWS

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,9 @@ Library
169169
Build
170170
-----
171171

172+
- Issue #15759: "make suspicious", "make linkcheck" and "make doctest" in Doc/
173+
now display special message when and only when there are failures.
174+
172175
- Issue #17095: Fix Modules/Setup *shared* support.
173176

174177
- Issue #21811: Anticipated fixes to support OS X versions > 10.9.

0 commit comments

Comments
 (0)