Cleanup clear_static_tp_subclasses() (#106276)

vstinner · web-flow · commit 1a2652ceaa55 · 2023-06-30T10:39:55.000Z
Only iterate on the dictionary if Python is built with assertions:
subclass is only needed when Python is built with assertions.
diff --git a/Objects/typeobject.c b/Objects/typeobject.c
@@ -5009,6 +5009,7 @@ clear_static_tp_subclasses(PyTypeObject *type)
        going to leak.  This mostly only affects embedding scenarios.
      */
 
+#ifndef NDEBUG
     // For now we just do a sanity check and then clear tp_subclasses.
     Py_ssize_t i = 0;
     PyObject *key, *ref;  // borrowed ref
@@ -5021,6 +5022,7 @@ clear_static_tp_subclasses(PyTypeObject *type)
         assert(!(subclass->tp_flags & _Py_TPFLAGS_STATIC_BUILTIN));
         Py_DECREF(subclass);
     }
+#endif
 
     clear_tp_subclasses(type);
 }

Original file line number	Diff line number	Diff line change
`@@ -5009,6 +5009,7 @@ clear_static_tp_subclasses(PyTypeObject *type)`
`5009`	`5009`	`going to leak. This mostly only affects embedding scenarios.`
`5010`	`5010`	`*/`
`5011`	`5011`
	`5012`	`+#ifndef NDEBUG`
`5012`	`5013`	`// For now we just do a sanity check and then clear tp_subclasses.`
`5013`	`5014`	`Py_ssize_t i = 0;`
`5014`	`5015`	`PyObject key, ref; // borrowed ref`
`@@ -5021,6 +5022,7 @@ clear_static_tp_subclasses(PyTypeObject *type)`
`5021`	`5022`	`assert(!(subclass->tp_flags & _Py_TPFLAGS_STATIC_BUILTIN));`
`5022`	`5023`	`Py_DECREF(subclass);`
`5023`	`5024`	`}`
	`5025`	`+#endif`
`5024`	`5026`
`5025`	`5027`	`clear_tp_subclasses(type);`
`5026`	`5028`	`}`