Deprecate co_lnotab instead of removing it

sobolevn · sobolevn · commit 1a6b7bb5f7a2 · 2023-02-21T17:22:40.000+03:00
diff --git a/Doc/whatsnew/3.12.rst b/Doc/whatsnew/3.12.rst
@@ -516,6 +516,12 @@ Pending Removal in Python 3.14
   functions that have been deprecated since Python 2 but only gained a
   proper :exc:`DeprecationWarning` in 3.12. Remove them in 3.14.
 
+* Accessing ``co_lnotab`` was deprecated in :pep:`626` since 3.10
+  and was planned to be removed in 3.12
+  but it only got a proper :exc:`DeprecationWarning` in 3.12.
+  Remove it in 3.14.
+  (Contributed by Nikita Sobolev in :gh:`101866`.)
+
 Pending Removal in Future Versions
 ----------------------------------
 
diff --git a/Lib/test/test_code.py b/Lib/test/test_code.py
@@ -338,6 +338,13 @@ def func():
         new_code = code = func.__code__.replace(co_linetable=b'')
         self.assertEqual(list(new_code.co_lines()), [])
 
+    def test_co_lnotab_is_deprecated(self):  # TODO: remove in 3.14
+        def func():
+            pass
+
+        with self.assertWarns(DeprecationWarning):
+            func.__code__.co_lnotab
+
     def test_invalid_bytecode(self):
         def foo():
             pass
diff --git a/Misc/NEWS.d/next/Core and Builtins/2023-02-21-17-22-06.gh-issue-101865.fwrTOA.rst b/Misc/NEWS.d/next/Core and Builtins/2023-02-21-17-22-06.gh-issue-101865.fwrTOA.rst
@@ -0,0 +1,2 @@
+Deprecate ``co_lnotab`` in code objects, schedule it for removal in Python
+3.14
diff --git a/Objects/codeobject.c b/Objects/codeobject.c
@@ -1884,6 +1884,13 @@ static PyMemberDef code_memberlist[] = {
 static PyObject *
 code_getlnotab(PyCodeObject *code, void *closure)
 {
+    if (PyErr_WarnEx(PyExc_DeprecationWarning,
+                     "co_lnotab is deprecated since Python 3.12 "
+                     "and will be removed in Python 3.14, "
+                     "use co_lines instead.",
+                     1) < 0) {
+        return NULL;
+    }
     return decode_linetable(code);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+Deprecate ``co_lnotab`` in code objects, schedule it for removal in Python
	`2`	`+3.14`
Original file line number	Diff line number	Diff line change
`@@ -1884,6 +1884,13 @@ static PyMemberDef code_memberlist[] = {`
`1884`	`1884`	`static PyObject *`
`1885`	`1885`	`code_getlnotab(PyCodeObject code, void closure)`
`1886`	`1886`	`{`
	`1887`	`+ if (PyErr_WarnEx(PyExc_DeprecationWarning,`
	`1888`	`+ "co_lnotab is deprecated since Python 3.12 "`
	`1889`	`+ "and will be removed in Python 3.14, "`
	`1890`	`+ "use co_lines instead.",`
	`1891`	`+ 1) < 0) {`
	`1892`	`+ return NULL;`
	`1893`	`+ }`
`1887`	`1894`	`return decode_linetable(code);`
`1888`	`1895`	`}`
`1889`	`1896`