bpo-37219: Remove erroneous optimization for differencing an empty set (GH-13965)

rhettinger · web-flow · commit 1f11cf952111 · 2019-06-11T01:15:24.000-07:00
diff --git a/Lib/test/test_set.py b/Lib/test/test_set.py
@@ -895,6 +895,12 @@ def test_pickling(self):
             self.assertEqual(self.set, copy,
                              "%s != %s" % (self.set, copy))
 
+    def test_issue_37219(self):
+        with self.assertRaises(TypeError):
+            set().difference(123)
+        with self.assertRaises(TypeError):
+            set().difference_update(123)
+
 #------------------------------------------------------------------------------
 
 class TestBasicOpsEmpty(TestBasicOps, unittest.TestCase):
diff --git a/Misc/NEWS.d/next/Core and Builtins/2019-06-10-23-18-31.bpo-37219.jPSufq.rst b/Misc/NEWS.d/next/Core and Builtins/2019-06-10-23-18-31.bpo-37219.jPSufq.rst
@@ -0,0 +1 @@
+Remove errorneous optimization for empty set differences.
diff --git a/Objects/setobject.c b/Objects/setobject.c
@@ -1456,10 +1456,6 @@ PyDoc_STRVAR(isdisjoint_doc,
 static int
 set_difference_update_internal(PySetObject *so, PyObject *other)
 {
-    if (PySet_GET_SIZE(so) == 0) {
-        return 0;
-    }
-
     if ((PyObject *)so == other)
         return set_clear_internal(so);
 
@@ -1534,10 +1530,6 @@ set_difference(PySetObject *so, PyObject *other)
     Py_ssize_t pos = 0, other_size;
     int rv;
 
-    if (PySet_GET_SIZE(so) == 0) {
-        return set_copy(so, NULL);
-    }
-
     if (PyAnySet_Check(other)) {
         other_size = PySet_GET_SIZE(other);
     }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Remove errorneous optimization for empty set differences.`