Issue #19986: Avoid an incorrect warning of older gcc versions.

Stefan Krah · Stefan Krah · commit 1f1ec12db9ee · 2013-12-15T20:45:08.000+01:00
diff --git a/Modules/_decimal/libmpdec/mpdecimal.c b/Modules/_decimal/libmpdec/mpdecimal.c
@@ -4421,21 +4421,22 @@ mpd_qfma(mpd_t *result, const mpd_t *a, const mpd_t *b, const mpd_t *c,
          const mpd_context_t *ctx, uint32_t *status)
 {
     uint32_t workstatus = 0;
-    const mpd_t *cc = c;
+    mpd_t *cc = NULL;
 
     if (result == c) {
         if ((cc = mpd_qncopy(c)) == NULL) {
             mpd_seterror(result, MPD_Malloc_error, status);
             return;
         }
+        c = cc;
     }
 
     _mpd_qmul(result, a, b, ctx, &workstatus);
     if (!(workstatus&MPD_Invalid_operation)) {
-        mpd_qadd(result, result, cc, ctx, &workstatus);
+        mpd_qadd(result, result, c, ctx, &workstatus);
     }
 
-    if (cc != c) mpd_del((mpd_t *)cc);
+    if (cc) mpd_del(cc);
     *status |= workstatus;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -4421,21 +4421,22 @@ mpd_qfma(mpd_t result, const mpd_t a, const mpd_t b, const mpd_t c,`
`4421`	`4421`	`const mpd_context_t ctx, uint32_t status)`
`4422`	`4422`	`{`
`4423`	`4423`	`uint32_t workstatus = 0;`
`4424`		`- const mpd_t *cc = c;`
	`4424`	`+ mpd_t *cc = NULL;`
`4425`	`4425`
`4426`	`4426`	`if (result == c) {`
`4427`	`4427`	`if ((cc = mpd_qncopy(c)) == NULL) {`
`4428`	`4428`	`mpd_seterror(result, MPD_Malloc_error, status);`
`4429`	`4429`	`return;`
`4430`	`4430`	`}`
	`4431`	`+ c = cc;`
`4431`	`4432`	`}`
`4432`	`4433`
`4433`	`4434`	`_mpd_qmul(result, a, b, ctx, &workstatus);`
`4434`	`4435`	`if (!(workstatus&MPD_Invalid_operation)) {`
`4435`		`- mpd_qadd(result, result, cc, ctx, &workstatus);`
	`4436`	`+ mpd_qadd(result, result, c, ctx, &workstatus);`
`4436`	`4437`	`}`
`4437`	`4438`
`4438`		`- if (cc != c) mpd_del((mpd_t *)cc);`
	`4439`	`+ if (cc) mpd_del(cc);`
`4439`	`4440`	`*status \|= workstatus;`
`4440`	`4441`	`}`
`4441`	`4442`