builtin_map(): Nailed memory leak. PyList_Append() borrows a

warsaw · warsaw · commit 2133287c3ed1 · 1999-01-28T04:21:35.000Z
reference, so you have to DECREF the appended value.  This was a fun
one!
diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c
@@ -903,6 +903,7 @@ builtin_map(self, args)
 		if (i >= len) {
 			if (PyList_Append(result, value) < 0)
 				goto Fail_1;
+			Py_DECREF(value);
 		}
 		else {
 			if (PyList_SetItem(result, i, value) < 0)

Original file line number	Diff line number	Diff line change
`@@ -903,6 +903,7 @@ builtin_map(self, args)`
`903`	`903`	`if (i >= len) {`
`904`	`904`	`if (PyList_Append(result, value) < 0)`
`905`	`905`	`goto Fail_1;`
	`906`	`+ Py_DECREF(value);`
`906`	`907`	`}`
`907`	`908`	`else {`
`908`	`909`	`if (PyList_SetItem(result, i, value) < 0)`