getbuffer(): release the buffer on error (if the buffer is not contiguous)

Victor Stinner · Victor Stinner · commit 21e09487ac9d · 2010-06-24T22:57:10.000Z
diff --git a/Python/getargs.c b/Python/getargs.c
@@ -1340,6 +1340,7 @@ getbuffer(PyObject *arg, Py_buffer *view, char **errmsg)
         return -1;
     }
     if (!PyBuffer_IsContiguous(view, 'C')) {
+        PyBuffer_Release(view);
         *errmsg = "contiguous buffer";
         return -1;
     }

Original file line number	Diff line number	Diff line change
`@@ -1340,6 +1340,7 @@ getbuffer(PyObject arg, Py_buffer view, char **errmsg)`
`1340`	`1340`	`return -1;`
`1341`	`1341`	`}`
`1342`	`1342`	`if (!PyBuffer_IsContiguous(view, 'C')) {`
	`1343`	`+ PyBuffer_Release(view);`
`1343`	`1344`	`*errmsg = "contiguous buffer";`
`1344`	`1345`	`return -1;`
`1345`	`1346`	`}`