Issue #14592: A relative import will raise a KeyError if __package__

brettcannon · brettcannon · commit 273323cf68e8 · 2012-04-17T19:05:11.000-04:00
or __name__ are not set in globals.

Thanks to Stefan Behnel for the bug report.
diff --git a/Lib/importlib/test/import_/test_relative_imports.py b/Lib/importlib/test/import_/test_relative_imports.py
@@ -203,6 +203,11 @@ def callback(global_):
             self.assertEqual(mod.__name__, 'crash.mod')
         self.relative_import_test(create, globals_, callback)
 
+    def test_relative_import_no_globals(self):
+        # No globals for a relative import is an error.
+        with self.assertRaises(KeyError):
+            import_util.import_('sys', level=1)
+
 
 def test_main():
     from test.support import run_unittest
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -10,6 +10,9 @@ What's New in Python 3.3.0 Alpha 3?
 Core and Builtins
 -----------------
 
+- Issue #14592: Attempting a relative import w/o __package__ or __name__ set in
+  globals raises a KeyError.
+
 - Issue #10854: The ImportError raised when an extension module on Windows
   fails to import now uses the new path and name attributes from
   Issue #1559549.
diff --git a/Python/import.c b/Python/import.c
@@ -2355,8 +2355,9 @@ PyImport_ImportModuleLevelObject(PyObject *name, PyObject *given_globals,
             }
         }
         else {
-            package = _PyDict_GetItemIdWithError(globals, &PyId___name__);
+            package = _PyDict_GetItemId(globals, &PyId___name__);
             if (package == NULL) {
+                PyErr_SetString(PyExc_KeyError, "'__name__' not in globals");
                 goto error;
             }
             else if (!PyUnicode_Check(package)) {

Original file line number	Diff line number	Diff line change
`@@ -2355,8 +2355,9 @@ PyImport_ImportModuleLevelObject(PyObject name, PyObject given_globals,`
`2355`	`2355`	`}`
`2356`	`2356`	`}`
`2357`	`2357`	`else {`
`2358`		`- package = _PyDict_GetItemIdWithError(globals, &PyId___name__);`
	`2358`	`+ package = _PyDict_GetItemId(globals, &PyId___name__);`
`2359`	`2359`	`if (package == NULL) {`
	`2360`	`+ PyErr_SetString(PyExc_KeyError, "'__name__' not in globals");`
`2360`	`2361`	`goto error;`
`2361`	`2362`	`}`
`2362`	`2363`	`else if (!PyUnicode_Check(package)) {`