bpo-44256: Do not expose _functools._list_elem_type (GH-26416)

methane · web-flow · commit 28be3191a9db · 2021-05-28T14:09:32.000+09:00
It is internal use only type.
diff --git a/Modules/_functoolsmodule.c b/Modules/_functoolsmodule.c
@@ -1460,9 +1460,8 @@ _functools_exec(PyObject *module)
     if (state->lru_list_elem_type == NULL) {
         return -1;
     }
-    if (PyModule_AddType(module, state->lru_list_elem_type) < 0) {
-        return -1;
-    }
+    // lru_list_elem is used only in _lru_cache_wrapper.
+    // So we don't expose it in module namespace.
 
     return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -1460,9 +1460,8 @@ _functools_exec(PyObject *module)`
`1460`	`1460`	`if (state->lru_list_elem_type == NULL) {`
`1461`	`1461`	`return -1;`
`1462`	`1462`	`}`
`1463`		`- if (PyModule_AddType(module, state->lru_list_elem_type) < 0) {`
`1464`		`- return -1;`
`1465`		`- }`
	`1463`	`+ // lru_list_elem is used only in _lru_cache_wrapper.`
	`1464`	`+ // So we don't expose it in module namespace.`
`1466`	`1465`
`1467`	`1466`	`return 0;`
`1468`	`1467`	`}`