Issue #19019: Change the OS X installer build script to use CFLAGS instead

ned-deily · ned-deily · commit 29eec66711d8 · 2013-10-18T21:16:05.000-07:00
of OPT for special build options.  By setting OPT, some compiler-specific
options like -fwrapv were overridden and thus not used, which could result
in broken interpreters when building with clang.
diff --git a/Mac/BuildScript/build-installer.py b/Mac/BuildScript/build-installer.py
@@ -952,7 +952,7 @@ def buildPython():
                "--with-universal-archs=%s "
                "%s "
                "LDFLAGS='-g -L%s/libraries/usr/local/lib' "
-               "OPT='-g -O3 -I%s/libraries/usr/local/include' 2>&1"%(
+               "CFLAGS='-g -I%s/libraries/usr/local/include' 2>&1"%(
         shellQuote(os.path.join(SRCDIR, 'configure')), shellQuote(SDKPATH),
         UNIVERSALARCHS,
         (' ', '--with-computed-gotos ')[PYTHON_3],
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -196,6 +196,11 @@ Build
     3. -sysroot and -arch flags were unnecessarily duplicated
     4. there was no obvious way to configure an intel-32 only build.
 
+- Issue #19019: Change the OS X installer build script to use CFLAGS instead
+  of OPT for special build options.  By setting OPT, some compiler-specific
+  options like -fwrapv were overridden and thus not used, which could result
+  in broken interpreters when building with clang.
+
 What's New in Python 3.4.0 Alpha 3?
 ===================================
 
