Issue #22421 - Secure pydoc server run. Bind it to localhost instead of all interfaces.

orsenthil · orsenthil · commit 2a42a0bff361 · 2014-09-17T13:17:58.000+08:00
diff --git a/Lib/pydoc.py b/Lib/pydoc.py
@@ -2168,8 +2168,8 @@ def log_message(self, *args):
     class DocServer(http.server.HTTPServer):
 
         def __init__(self, port, callback):
-            self.host = (sys.platform == 'mac') and '127.0.0.1' or 'localhost'
-            self.address = ('', port)
+            self.host = 'localhost'
+            self.address = (self.host, port)
             self.callback = callback
             self.base.__init__(self, self.address, self.handler)
             self.quit = False
diff --git a/Lib/test/test_pydoc.py b/Lib/test/test_pydoc.py
@@ -557,6 +557,8 @@ def my_url_handler(url, content_type):
             return text
 
         serverthread = pydoc._start_server(my_url_handler, port=0)
+        self.assertIn('localhost', serverthread.docserver.address)
+
         starttime = time.time()
         timeout = 1  #seconds
 
