SF patch #102548, fix for bug #121013, by mwh@users.sourceforge.net.

gvanrossum · gvanrossum · commit 2ccda8a7c4b9 · 2000-11-27T18:46:26.000Z
Fixes a typo that caused "".join(u"this is a test") to dump core.
diff --git a/Objects/stringobject.c b/Objects/stringobject.c
@@ -835,7 +835,7 @@ string_join(PyStringObject *self, PyObject *args)
 			if (PyUnicode_Check(item)) {
 				Py_DECREF(res);
 				Py_DECREF(seq);
-				return PyUnicode_Join((PyObject *)self, seq);
+				return PyUnicode_Join((PyObject *)self, orig);
 			}
 			PyErr_Format(PyExc_TypeError,
 				     "sequence item %i: expected string,"

Original file line number	Diff line number	Diff line change
`@@ -835,7 +835,7 @@ string_join(PyStringObject self, PyObject args)`
`835`	`835`	`if (PyUnicode_Check(item)) {`
`836`	`836`	`Py_DECREF(res);`
`837`	`837`	`Py_DECREF(seq);`
`838`		`- return PyUnicode_Join((PyObject *)self, seq);`
	`838`	`+ return PyUnicode_Join((PyObject *)self, orig);`
`839`	`839`	`}`
`840`	`840`	`PyErr_Format(PyExc_TypeError,`
`841`	`841`	`"sequence item %i: expected string,"`