Issue #6477: Merge with 3.3.

avassalotti · avassalotti · commit 2ccf8e969c5e · 2013-11-30T17:58:53.000-08:00
diff --git a/Include/object.h b/Include/object.h
@@ -829,8 +829,8 @@ they can have object code that is not dependent on Python compilation flags.
 PyAPI_FUNC(void) Py_IncRef(PyObject *);
 PyAPI_FUNC(void) Py_DecRef(PyObject *);
 
-PyAPI_DATA(PyTypeObject) PyNone_Type;
-PyAPI_DATA(PyTypeObject) PyNotImplemented_Type;
+PyAPI_DATA(PyTypeObject) _PyNone_Type;
+PyAPI_DATA(PyTypeObject) _PyNotImplemented_Type;
 
 /*
 _Py_NoneStruct is an object of undefined type which can be used in contexts
diff --git a/Modules/_pickle.c b/Modules/_pickle.c
@@ -3305,13 +3305,13 @@ save_singleton_type(PicklerObject *self, PyObject *obj, PyObject *singleton)
 static int
 save_type(PicklerObject *self, PyObject *obj)
 {
-    if (obj == (PyObject *)&PyNone_Type) {
+    if (obj == (PyObject *)&_PyNone_Type) {
         return save_singleton_type(self, obj, Py_None);
     }
     else if (obj == (PyObject *)&PyEllipsis_Type) {
         return save_singleton_type(self, obj, Py_Ellipsis);
     }
-    else if (obj == (PyObject *)&PyNotImplemented_Type) {
+    else if (obj == (PyObject *)&_PyNotImplemented_Type) {
         return save_singleton_type(self, obj, Py_NotImplemented);
     }
     return save_global(self, obj, NULL);
diff --git a/Objects/object.c b/Objects/object.c
@@ -1409,7 +1409,7 @@ static PyNumberMethods none_as_number = {
     0,                          /* nb_index */
 };
 
-PyTypeObject PyNone_Type = {
+PyTypeObject _PyNone_Type = {
     PyVarObject_HEAD_INIT(&PyType_Type, 0)
     "NoneType",
     0,
@@ -1452,7 +1452,7 @@ PyTypeObject PyNone_Type = {
 
 PyObject _Py_NoneStruct = {
   _PyObject_EXTRA_INIT
-  1, &PyNone_Type
+  1, &_PyNone_Type
 };
 
 /* NotImplemented is an object that can be used to signal that an
@@ -1494,7 +1494,7 @@ notimplemented_dealloc(PyObject* ignore)
     Py_FatalError("deallocating NotImplemented");
 }
 
-PyTypeObject PyNotImplemented_Type = {
+PyTypeObject _PyNotImplemented_Type = {
     PyVarObject_HEAD_INIT(&PyType_Type, 0)
     "NotImplementedType",
     0,
@@ -1537,7 +1537,7 @@ PyTypeObject PyNotImplemented_Type = {
 
 PyObject _Py_NotImplementedStruct = {
     _PyObject_EXTRA_INIT
-    1, &PyNotImplemented_Type
+    1, &_PyNotImplemented_Type
 };
 
 void
@@ -1567,10 +1567,10 @@ _Py_ReadyTypes(void)
     if (PyType_Ready(&PyList_Type) < 0)
         Py_FatalError("Can't initialize list type");
 
-    if (PyType_Ready(&PyNone_Type) < 0)
+    if (PyType_Ready(&_PyNone_Type) < 0)
         Py_FatalError("Can't initialize None type");
 
-    if (PyType_Ready(&PyNotImplemented_Type) < 0)
+    if (PyType_Ready(&_PyNotImplemented_Type) < 0)
         Py_FatalError("Can't initialize NotImplemented type");
 
     if (PyType_Ready(&PyTraceBack_Type) < 0)

Original file line number	Diff line number	Diff line change
`@@ -3305,13 +3305,13 @@ save_singleton_type(PicklerObject self, PyObject obj, PyObject *singleton)`
`3305`	`3305`	`static int`
`3306`	`3306`	`save_type(PicklerObject self, PyObject obj)`
`3307`	`3307`	`{`
`3308`		`- if (obj == (PyObject *)&PyNone_Type) {`
	`3308`	`+ if (obj == (PyObject *)&_PyNone_Type) {`
`3309`	`3309`	`return save_singleton_type(self, obj, Py_None);`
`3310`	`3310`	`}`
`3311`	`3311`	`else if (obj == (PyObject *)&PyEllipsis_Type) {`
`3312`	`3312`	`return save_singleton_type(self, obj, Py_Ellipsis);`
`3313`	`3313`	`}`
`3314`		`- else if (obj == (PyObject *)&PyNotImplemented_Type) {`
	`3314`	`+ else if (obj == (PyObject *)&_PyNotImplemented_Type) {`
`3315`	`3315`	`return save_singleton_type(self, obj, Py_NotImplemented);`
`3316`	`3316`	`}`
`3317`	`3317`	`return save_global(self, obj, NULL);`